589485 - modules/libpr0n/decoders/icon/gtk/Makefile.in uses MOZ_GNOMEUI_CFLAGS which is never set

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, defect)

Description

[Robert Kaiser]

I get the following error in my build:
In file included from /mnt/mozilla/hg/comm-central/mozilla/modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp:45:0:
../../../../../dist/system_wrappers/libgnome/libgnome.h:3:36: fatal error: libgnome/libgnome.h: No such file or directory
compilation terminated.
gmake[7]: *** [nsIconChannel.o] Error 1
gmake[7]: Leaving directory `/mnt/mozilla/build/seamonkey-de/mozilla/modules/libpr0n/decoders/icon/gtk'

On closer investigation, I found the GTK includes missing in the command line, whcih might be due to http://mxr.mozilla.org/comm-central/source/mozilla/modules/libpr0n/decoders/icon/gtk/Makefile.in#52 and MOZ_ENABLE_GNOMEUI being set.

http://mxr.mozilla.org/comm-central/search?string=MOZ_GNOMEUI_CFLAGS turned up that this variable is never set, which can't be a good idea when it's used like that.

A fun fact is that it's been introduced in bug 225148 and even never defined back then.

And I guess bug 402742 now ensuring that libgnome etc. are there are the problem why it ends up failing now, as before LOCAL_INCLUDES was always empty, now it's only empty if MOZ_ENABLE_GNOMEUI is set.

I just wonder why our official builds aren't busted, are they without gnomeui support?

Comment 1

[Robert Kaiser]

Actually, strangely, MOZ_GNOMEUI_CFLAGS is set in autoconfig.mk in a slightly older build on a different computer of mine - even though I have no clue where it gets set.

Comment 2

[Robert Kaiser]

Oh, I guess, PKG_CHECK_MODULES(MOZ_GNOMEUI, [...]) does define it - or should.

Comment 3

[Robert Kaiser]

OK, pkg-config still gives the right stuff, but that doesn't end up in autoconf.mk:

> pkg-config --libs libgnomeui-2.0
-pthread -lgnomeui-2 -lSM -lICE -lbonoboui-2 -lgnomevfs-2 -lgnomecanvas-2 -lgnome-2 -lpopt -lbonobo-2 -lbonobo-activation -lORBit-2 -lart_lgpl_2 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lm -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgconf-2 -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0

Comment 4

[Robert Kaiser]

My build log says:
checking for libgnomeui-2.0 >= 2.2.0... yes
checking MOZ_GNOMEUI_CFLAGS... -DORBIT2=1 -pthread -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1 -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/gail-1.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12  
checking MOZ_GNOMEUI_LIBS... -pthread -lgnomeui-2 -lSM -lICE -lbonoboui-2 -lgnomevfs-2 -lgnomecanvas-2 -lgnome-2 -lpopt -lbonobo-2 -lbonobo-activation -lORBit-2 -lart_lgpl_2 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgconf-2 -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0  

My autoconf.mk says:
MOZ_ENABLE_GNOMEUI = 1
MOZ_GNOMEUI_CFLAGS = 
MOZ_GNOMEUI_LIBS = -pthread -lgnomeui-2 -lSM -lICE -lbonoboui-2 -lgnomevfs-2 -lgnomecanvas-2 -lgnome-2 -lpopt -lbonobo-2 -lbonobo-activation -lORBit-2 -lart_lgpl_2 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lm -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgconf-2 -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0

Comment 5

[Robert Kaiser]

Oh, wait, seems to be local failure:

> pkg-config --cflags libgnomeui-2.0
Package libcanberra was not found in the pkg-config search path.
Perhaps you should add the directory containing `libcanberra.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libcanberra', required by 'libgnome', not found

Comment 6

[Robert Kaiser]

of course, I don't have any idea why the build log says configure found cflags when pkg-config doesn't. But I'll look for libcanberra and hope to get this going again.

Comment 7

[Robert Kaiser]

libcanberra-devel was missing. I guess I need to report to the distro folks that they need to fix dependencies.