Closed Bug 589504 Opened 11 years ago Closed 10 years ago

Remove --enable-boehm and related code from NSPR

Categories

(NSPR :: NSPR, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: t.matsuu)

Details

Attachments

(2 files)

In some related work with cleaning up configure vars I noticed NSPR still uses |GC_LEAK_DETECTOR| throughout much of the codebase. This var is no longer used in m-c (or comm-central) at all.

NSPR's usage allows those building NSPR directly to |--enable-boehm|.

Is there some reason this is still present in NSPR (other than "we didn't get around to it") or can/should it be removed?
I believe that code can be removed.  I don't think
it's being built unless you specify some configure
option.
Attachment #468227 - Flags: review?(ted.mielczarek)
I'll take care of this bug.
Attachment #468228 - Flags: review?(wtc)
Assignee: bugspam.Callek → t.matsuu
OS: Windows XP → All
Hardware: x86 → All
Comment on attachment 468228 [details] [diff] [review]
Remove GC_LEAK_DETECTOR from NSPR part (checked in)

r=wtc.  We should also cvs remove prgcleak.c, right?
Attachment #468228 - Flags: review?(wtc) → review+
(In reply to comment #4)
> r=wtc.  We should also cvs remove prgcleak.c, right?

Yes. prgleak.c is compiled only when GC_LEAK_DETECTOR is defined.
Comment on attachment 468227 [details] [diff] [review]
Remove GC_LEAK_DETECTOR from build config part

This looks good to me, but I'm not an official reviewer
Attachment #468227 - Flags: review+
Comment on attachment 468228 [details] [diff] [review]
Remove GC_LEAK_DETECTOR from NSPR part (checked in)

Patch (including cvs remove prgcleak.c) checked in on the NSPR trunk (NSPR 4.8.7).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.286; previous revision: 1.285
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.290; previous revision: 1.289
done
Checking in config/autoconf.mk.in;
/cvsroot/mozilla/nsprpub/config/autoconf.mk.in,v  <--  autoconf.mk.in
new revision: 1.43; previous revision: 1.42
done
Checking in pr/include/private/primpl.h;
/cvsroot/mozilla/nsprpub/pr/include/private/primpl.h,v  <--  primpl.h
new revision: 3.93; previous revision: 3.92
done
Checking in pr/src/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/Makefile.in,v  <--  Makefile.in
new revision: 1.59; previous revision: 1.58
done
Checking in pr/src/memory/Makefile.in;
/cvsroot/mozilla/nsprpub/pr/src/memory/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
Removing pr/src/memory/prgcleak.c;
/cvsroot/mozilla/nsprpub/pr/src/memory/prgcleak.c,v  <--  prgcleak.c
new revision: delete; previous revision: 1.2
done
Checking in pr/src/misc/prinit.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prinit.c,v  <--  prinit.c
new revision: 3.57; previous revision: 3.56
done
Checking in pr/src/misc/prthinfo.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prthinfo.c,v  <--  prthinfo.c
new revision: 3.12; previous revision: 3.11
done
Checking in pr/src/pthreads/ptthread.c;
/cvsroot/mozilla/nsprpub/pr/src/pthreads/ptthread.c,v  <--  ptthread.c
new revision: 3.89; previous revision: 3.88
done
Checking in pr/src/threads/combined/pruthr.c;
/cvsroot/mozilla/nsprpub/pr/src/threads/combined/pruthr.c,v  <--  pruthr.c
new revision: 3.41; previous revision: 3.40
done
Attachment #468228 - Attachment description: Remove GC_LEAK_DETECTOR from NSPR part → Remove GC_LEAK_DETECTOR from NSPR part (checked in)
Severity: normal → trivial
Status: NEW → ASSIGNED
Keywords: checkin-needed
Priority: -- → P2
Target Milestone: --- → 4.8.7
Attachment #468227 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 468227 [details] [diff] [review]
Remove GC_LEAK_DETECTOR from build config part

I suppose attachment 468227 [details] [diff] [review] is low risk because gc/boehm does not exist in m-c now.
Attachment #468227 - Flags: approval2.0?
Please check in attachment 468227 [details] [diff] [review] because NSPR_HEAD_20101015 which includes attachment 468228 [details] [diff] [review] has been merged into m-c.

http://hg.mozilla.org/mozilla-central/rev/38cf9ade344b
Whiteboard: [need landing]
Attachment #468227 - Flags: approval2.0? → approval2.0+
Landed attachment 468227 [details] [diff] [review] on mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/91465997ac12
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [need landing]
You need to log in before you can comment on or make changes to this bug.