Closed Bug 589524 Opened 9 years ago Closed 9 years ago

Remove accesskeys for the Firefox button menu items, that have them assigned

Categories

(Firefox :: Menus, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b5

People

(Reporter: wladow, Assigned: wladow)

References

Details

(Keywords: polish)

Attachments

(1 file)

The "Start private browsing" and "Work offline" items have accesskeys assigned in the Firefox button menu. Those are the main menu code leftovers and should be removed. If we decide to use accesskeys in this menu in the future, we will have to use new accesskeys, reusing the ones used in the main menu is not the way. A patch follows.
Attached patch remove themSplinter Review
Attachment #468119 - Flags: review?(dolske)
Attachment #468119 - Flags: review?(dolske)
Attachment #468119 - Flags: review+
Attachment #468119 - Flags: approval2.0+
Landed:
http://hg.mozilla.org/mozilla-central/rev/89d517900126
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
Depends on: 616836
I added a test for this in bug 616836: http://hg.mozilla.org/mozilla-central/rev/897cca515280
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.