Closed
Bug 589533
Opened 11 years ago
Closed 8 years ago
Cursor at end of text of import calendar list pop-up/popup/window/dialog
Categories
(Calendar :: Import and Export, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1
People
(Reporter: aryx, Assigned: aryx)
Details
Attachments
(2 files, 1 obsolete file)
6.40 KB,
image/png
|
Details | |
2.05 KB,
patch
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Lightning/1.0b2 Thunderbird/3.1.2 I can see a cursor cursor at the end of the import calendar list pop-up/popup/window/dialog.
Updated•9 years ago
|
Version: Trunk → Lightning 1.0b2
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Fallen, are you okay with a patch replacing the textbox with a description with a text child node in chooseCalendarDialog.xul? This works for me in a test: <description id="prompt"></description> and document.getElementById("prompt").textContent = window.arguments[0].promptText;
Comment 2•9 years ago
|
||
Looks like the review comment from bug 323085 comment 17 was never actually taken care of ;-) Yes, that sounds good. While you are here, could you also add some accessibility features, I think it was: <description id="prompt" for="id-of-listbox"/> Please doublecheck.
![]() |
Assignee | |
Comment 3•9 years ago
|
||
For XUL label, it's control="id", not for="id" like in HTML.
Comment 4•8 years ago
|
||
Comment on attachment 672053 [details] [diff] [review] patch: replace textbox with wrapping label in chooseCalendarDialog.xul, v1 Review of attachment 672053 [details] [diff] [review]: ----------------------------------------------------------------- r=philipp with the following nit fixed: ::: calendar/base/content/dialogs/chooseCalendarDialog.xul @@ +80,5 @@ > } > ]]></script> > > <vbox id="dialog-box" flex="1"> > + <label id="prompt" control="calendar-list"></label> To align with the rest, you could use a short close tag.
Attachment #672053 -
Flags: review?(philipp) → review+
![]() |
Assignee | |
Comment 5•8 years ago
|
||
Attachment #672053 -
Attachment is obsolete: true
![]() |
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Target Milestone: --- → 1.9
Updated•8 years ago
|
Target Milestone: 1.9 → 2.1
You need to log in
before you can comment on or make changes to this bug.
Description
•