589533 - Cursor at end of text of import calendar list pop-up/popup/window/dialog

Status: RESOLVED FIXED

Description

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Created attachment 468124 [details]
calendar import popup

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Lightning/1.0b2 Thunderbird/3.1.2

I can see a cursor cursor at the end of the import calendar list pop-up/popup/window/dialog.

Comment 1

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Fallen, are you okay with a patch replacing the textbox with a description with a text child node in chooseCalendarDialog.xul? This works for me in a test:

<description id="prompt"></description>

and

document.getElementById("prompt").textContent = window.arguments[0].promptText;

Comment 2

[Philipp Kewisch [:Fallen]]

Looks like the review comment from bug 323085 comment 17 was never actually taken care of ;-)

Yes, that sounds good. While you are here, could you also add some accessibility features, I think it was:

<description id="prompt" for="id-of-listbox"/>

Please doublecheck.

Comment 3

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Created attachment 672053 [details] [diff] [review]
patch: replace textbox with wrapping label in chooseCalendarDialog.xul, v1

For XUL label, it's control="id", not for="id" like in HTML.

Comment 4

[Philipp Kewisch [:Fallen]]

Comment on attachment 672053 [details] [diff] [review]
patch: replace textbox with wrapping label in chooseCalendarDialog.xul, v1

Review of attachment 672053 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with the following nit fixed:

::: calendar/base/content/dialogs/chooseCalendarDialog.xul
@@ +80,5 @@
>          }
>      ]]></script>
>  
>      <vbox id="dialog-box" flex="1">
> +        <label id="prompt" control="calendar-list"></label>

To align with the rest, you could use a short close tag.

Comment 5

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Created attachment 682592 [details] [diff] [review]
patch for checkin: replace textbox with label, v2

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/890a72806339