589550 - Traceback searching with escape-character sequence

Status: VERIFIED FIXED

(Input :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://input.stage.mozilla.com/en-US/sites?q=%BF%27%22%28 generates a 500 Internal Server Error; Dave/Fred -- can one of you provide the traceback?  Thanks.

Comment 1

[Fred Wenzel [:wenzel]]

Traceback (most recent call last):

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/decorators.py", line 76, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/input/decorators.py", line 33, in cached_view
    return f(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/views.py", line 82, in single_site
    if not form.is_valid():

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/forms/forms.py", line 121, in is_valid
    return self.is_bound and not bool(self.errors)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/forms/forms.py", line 112, in _get_errors
    self.full_clean()

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/forms/forms.py", line 268, in full_clean
    self._clean_form()

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/forms/forms.py", line 296, in _clean_form
    self.cleaned_data = self.clean()

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/forms.py", line 73, in clean
    if cleaned['page'] is not None:

KeyError: 'page'

Comment 2

[Fred Wenzel [:wenzel]]

That traceback was wrong, sorry. Here's the right one:

Traceback (most recent call last):

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/Django/django/utils/decorators.py", line 76, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/input/decorators.py", line 33, in cached_view
    return f(request, *args, **kwargs)

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/views.py", line 77, in website_issues
    return jingo.render(request, 'website_issues/website_issues.html', data)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 63, in render
    rendered = render_to_string(request, template, context)

  File "/data/www/input.stage.mozilla.com/reporter/vendor/src/jingo/jingo/__init__.py", line 84, in render_to_string
    return template.render(**get_context())

  File "/data/www/input.stage.mozilla.com/reporter/vendor/packages/jinja2/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/templates/website_issues/website_issues.html", line 6, in top-level template code
    href="{{ sites_url(form,**{name: value}) }}">{{ label }}</a>

  File "/data/www/input.stage.mozilla.com/reporter/templates/base.html", line 41, in top-level template code
    {% block content %}{% endblock %}

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/templates/website_issues/website_issues.html", line 22, in block "content"
    <li>{{ button('search_type', 'week', _('7d'), title=_('Last 7 days')) }}</li>

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/templates/website_issues/website_issues.html", line 6, in template
    href="{{ sites_url(form,**{name: value}) }}">{{ label }}</a>

  File "/data/www/input.stage.mozilla.com/reporter/apps/website_issues/helpers.py", line 43, in sites_url
    parts.extend(["?", urllib.urlencode(parameters)])

  File "/usr/lib/python2.6/urllib.py", line 1267, in urlencode
    v = quote_plus(str(v))

UnicodeEncodeError: 'ascii' codec can't encode character u'\ufffd' in position 0: ordinal not in range(128)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Cool, thanks -- makes more sense; is there a bug for comment 1's traceback?

Comment 4

[Fred Wenzel [:wenzel]]

No, I don't think there is, and sadly I don't really know how to reproduce that :(

Comment 5

[Fred Wenzel [:wenzel]]

Spoke too soon: Found the traceback and filed bug 590063.

Comment 6

[Fred Wenzel [:wenzel]]

We accidentally used a unicode-unaware urlencode() function. http://github.com/fwenzel/reporter/commit/fc71fdb

Might fix the other one too, I'll check.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!

Running PowerFuzzer now on staging...