xpti does not correctly handle an interface name change.

RESOLVED FIXED

Status

()

P3
normal
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: jband_mozilla, Assigned: jband_mozilla)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
The xpti (InterfaceInfo or Typelib reading) system has an AutoReg system that 
deals with detecting changes in .xpt files and .xpt in .zip files at startup 
(in debug builds). It fails to correctly handle the case where an interface 
descriptor has had only its name change. Developers sometimes do this as they 
change their code. If the iid changes or the interface descriptor is moved from 
one file to another then the change is detected and all is well. If only an 
interface name changes then the change is reflected into the type manifest 
(xpti.dat) and the *following* run of the app will see the change, but the 
current run will not.

I have a patch.
(Assignee)

Comment 1

18 years ago
Created attachment 18599 [details] [diff] [review]
proposed fix
(Assignee)

Comment 2

18 years ago
The bottom of the attached patch fixes this problem. 

The rest of the patch incorporates a part of the fix for bug 57370. This is a 
simple added method to allow us to compare iids on interfaceinfos without having 
to copy them from a getter call for compare. This is small and safe and I 
think it is better to get this in now rather than to fiddle my tree to remove 
the change.
(Assignee)

Comment 3

18 years ago
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.