589606 - No --disable-raw option, and raw decoder not built if all other media types disabled

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

There does not seems to be a --disable-raw build option. In fact it looks like raw video can't be disabled, and its configure section doesn't ensure MOZ_MEDIA is defined, so raw video will only be enabled when some other media type is enabled and that sets MOZ_MEDIA. i.e. If we build with --disable-wave, --disable-webm, and --disable-ogg, despite the fact that MOZ_RAW will still be defined, and the pref media.raw.enabled will be true, raw support won't be built because MOZ_MEDIA isn't defined.

There should be a --disable-raw option, and if raw video is not disabled, its configure section should ensure MOZ_MEDIA is defined, like the other media types' configure sections.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 469031 [details] [diff] [review]
Patch

Great, thanks!

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 469031 [details] [diff] [review]
Patch

Trivial build only consistency fix.  We should take this for 2.0.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 469031 [details] [diff] [review]
Patch

a=sdwilsh

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/b03fab95dda0