589741 - jetpack-core tests fail to even start: "setter functions must have one argument" in xhr.js

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/xhr.js", line 138, in null
    set upload() {
SyntaxError: setter functions must have one argument

Comment 1

[Drew Willcoxon :adw]

Minefield nightly?  http://whereswalden.com/2010/08/22/incompatible-es5-change-literal-getter-and-setter-functions-must-now-have-exactly-zero-or-one-arguments/

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Indeed.  Here's the fix.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 468500 [details] [diff] [review]
patch v1: fixes problem

Atul said he'd have time shortly to look at this.

Comment 4

[Atul Varma [:atul]]

Comment on attachment 468500 [details] [diff] [review]
patch v1: fixes problem

Looks good.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/a58f594784a5.

Comment 6

[Matěj Cepl]

How far is this downward compatible? How old version of firefox this breaks?

Comment 7

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".