589754 - Fail to build on sparc64

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Mike Hommey [:glandium]]

The configure check activates JIT on sparc*, but only defines AVMPLUS_SPARC on sparc. In sparc64 case, this leads to a failure to build, because it falls on
#error "unknown nanojit architecture".

Comment 1

[Mike Hommey [:glandium]]

Attachment: Define AVMPLUS_SPARC for sparc*

Comment 2

[Mike Hommey [:glandium]]

I'm starting to wonder. As far as my testing goes, nanojit works on sparc64. But I'm wondering if there shouldn't be a AC_DEFINE(AVMPLUS_64BIT) somewhere, in which case nanojit sparc doesn't have the necessary functions, e.g. asm_qbinop

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 468275 [details] [diff] [review]
Define AVMPLUS_SPARC for sparc*

Sorry, too late for 2.0.

Comment 4

[Mike Hommey [:glandium]]

I have doubts anyway, cf. comment 2.

Comment 5

[(not currently active) Ted Mielczarek]

This can land in the build-system branch (if you actually want it).

Comment 6

[Mike Hommey [:glandium]]

Let's mark it invalid, this predates the new jsvalue and since then sparc64 can't work properly. There is at least one bug for the js engine to work on sparc64.