Closed
Bug 589754
Opened 14 years ago
Closed 14 years ago
Fail to build on sparc64
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: glandium, Assigned: glandium)
Details
(Whiteboard: not-ready)
Attachments
(1 file)
|
443 bytes,
patch
|
benjamin
:
review+
joe
:
approval2.0-
|
Details | Diff | Splinter Review |
The configure check activates JIT on sparc*, but only defines AVMPLUS_SPARC on sparc. In sparc64 case, this leads to a failure to build, because it falls on
#error "unknown nanojit architecture".
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → mh+mozilla
Attachment #468275 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #468275 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #468275 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #468275 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 2•14 years ago
|
||
I'm starting to wonder. As far as my testing goes, nanojit works on sparc64. But I'm wondering if there shouldn't be a AC_DEFINE(AVMPLUS_64BIT) somewhere, in which case nanojit sparc doesn't have the necessary functions, e.g. asm_qbinop
|
||
Comment 3•14 years ago
|
||
Comment on attachment 468275 [details] [diff] [review]
Define AVMPLUS_SPARC for sparc*
Sorry, too late for 2.0.
Attachment #468275 -
Flags: approval2.0+ → approval2.0-
|
||
Comment 5•14 years ago
|
||
This can land in the build-system branch (if you actually want it).
|
||
Updated•14 years ago
|
Whiteboard: not-ready
|
|
Assignee | |
Comment 6•14 years ago
|
||
Let's mark it invalid, this predates the new jsvalue and since then sparc64 can't work properly. There is at least one bug for the js engine to work on sparc64.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•