589800 - Checkerboards are persistent on zoom of about:firstrun

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b4pre) Gecko/20100823 Namoroka/4.0b4pre Fennec/2.0a1pre

Note: This happened when setting tile.cache.size to 20 (as well as the default 10).

Steps to Reproduce:
1. Go to about:firstrun
2. Double tap to zoom into "Get Started"

Actual Results:
All I see are checkerboards

Expected Results:
The zoomed content within the "Get Started" snippet.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The only important line of the patch is the first change which remove startAnimation if the content is not remote to keep having a zoomTo rect.

The change is small and we could want that for a1

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/c84a5ad480fa

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: fixup

Oops, that patch broke pinch zooming on non-remote tabs.  This patch fixes that.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 468721 [details] [diff] [review]
fixup

Thanks for the code refactoring!

Comment 5

[Matt Brubeck (:mbrubeck)]

Pushed fixup: http://hg.mozilla.org/mobile-browser/rev/4653534ec23c

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100825 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100825 Namoroka/4.0b5pre Fennec/2.0a1pre