Closed Bug 589800 Opened 9 years ago Closed 9 years ago

Checkerboards are persistent on zoom of about:firstrun

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Maemo
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aakashd, Assigned: mbrubeck)

Details

Attachments

(2 files)

Build Id:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b4pre) Gecko/20100823 Namoroka/4.0b4pre Fennec/2.0a1pre

Note: This happened when setting tile.cache.size to 20 (as well as the default 10).

Steps to Reproduce:
1. Go to about:firstrun
2. Double tap to zoom into "Get Started"

Actual Results:
All I see are checkerboards

Expected Results:
The zoomed content within the "Get Started" snippet.
tracking-fennec: --- → ?
Attached patch PatchSplinter Review
The only important line of the patch is the first change which remove startAnimation if the content is not remote to keep having a zoomTo rect.

The change is small and we could want that for a1
Assignee: nobody → 21
Attachment #468652 - Flags: review?(mbrubeck)
Attachment #468652 - Flags: review?(mbrubeck) → review+
Attached patch fixupSplinter Review
Oops, that patch broke pinch zooming on non-remote tabs.  This patch fixes that.
Assignee: 21 → mbrubeck
Status: RESOLVED → REOPENED
Attachment #468721 - Flags: review?
Resolution: FIXED → ---
Attachment #468721 - Flags: review? → review?(21)
Comment on attachment 468721 [details] [diff] [review]
fixup

Thanks for the code refactoring!
Attachment #468721 - Flags: review?(21) → review+
Pushed fixup: http://hg.mozilla.org/mobile-browser/rev/4653534ec23c
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100825 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100825 Namoroka/4.0b5pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.