The default bug view has changed. See this FAQ.

Remove nsFileControlFrame::mTextFrame on trunk

RESOLVED FIXED in mozilla11

Status

()

Core
Layout: Form Controls
--
enhancement
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 468363 [details] [diff] [review]
fix

I don't see any reason for storing this frame pointer,
it's only used in two MouseClick methods and it's not
a performance problem to do the lookup there, AFAIK.

Removing it eliminates the risk of it becoming a stale pointer.
It also allows us to remove nsFileControlFrame::Reflow()
which now doesn't do anything besides calling the super class.
(Assignee)

Comment 1

5 years ago
Created attachment 575363 [details] [diff] [review]
fix
Attachment #468363 - Attachment is obsolete: true
Attachment #575363 - Flags: review?(bzbarsky)
Comment on attachment 575363 [details] [diff] [review]
fix

r=me
Attachment #575363 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fdc24d16d6d
Flags: in-testsuite-
Whiteboard: [inbound]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/1fdc24d16d6d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.