Last Comment Bug 589857 - Remove nsFileControlFrame::mTextFrame on trunk
: Remove nsFileControlFrame::mTextFrame on trunk
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Layout: Form Controls (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla11
Assigned To: Mats Palmgren (:mats)
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-23 10:56 PDT by Mats Palmgren (:mats)
Modified: 2012-02-01 13:59 PST (History)
1 user (show)
mats: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (12.62 KB, patch)
2010-08-23 10:56 PDT, Mats Palmgren (:mats)
no flags Details | Diff | Splinter Review
fix (10.66 KB, patch)
2011-11-17 18:56 PST, Mats Palmgren (:mats)
bzbarsky: review+
Details | Diff | Splinter Review

Description Mats Palmgren (:mats) 2010-08-23 10:56:24 PDT
Created attachment 468363 [details] [diff] [review]
fix

I don't see any reason for storing this frame pointer,
it's only used in two MouseClick methods and it's not
a performance problem to do the lookup there, AFAIK.

Removing it eliminates the risk of it becoming a stale pointer.
It also allows us to remove nsFileControlFrame::Reflow()
which now doesn't do anything besides calling the super class.
Comment 1 Mats Palmgren (:mats) 2011-11-17 18:56:31 PST
Created attachment 575363 [details] [diff] [review]
fix
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-11-17 19:00:50 PST
Comment on attachment 575363 [details] [diff] [review]
fix

r=me
Comment 4 Ed Morley [:emorley] 2011-11-18 02:58:37 PST
https://hg.mozilla.org/mozilla-central/rev/1fdc24d16d6d

Note You need to log in before you can comment on or make changes to this bug.