Qt widget/EGL does not work on Maemo anymore.

RESOLVED FIXED

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: romaxa, Unassigned)

Tracking

Firefox Tracking Flags

(fennec2.0b1+)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
it seems like after some latest changes we don't have EGL/GLLayerManager initialized properly anymore...

MOZ_ACCELERATED=1 does not enable EGL context

Comment 1

8 years ago
shouldn't GetLayerManager in the qt nsWindow return something other than the base widget's default layout manager?

e.g.:

new mozilla::layers::LayerManagerOGL(this);

Comment 2

8 years ago
Created attachment 469941 [details] [diff] [review]
Force parent widget in child widget creation

Problem was in child/parent relationship of widgets. Child widget was generated with aParent == null, aNativeParent != null. Because of this GetTopLevelWidget function didn't find correct widget. 

This patch forces nsBaseWidget to set parent. This is done in Qt ports CreateChildWidget.
Attachment #469941 - Flags: review?(romaxa)
(Reporter)

Comment 3

8 years ago
Comment on attachment 469941 [details] [diff] [review]
Force parent widget in child widget creation

I think we can handle it correctly, but probably it make sense make the same fix for GTK.
Attachment #469941 - Flags: review?(romaxa) → review+

Comment 4

8 years ago
this prevents us from rendering using ogl
tracking-fennec: --- → 2.0b1+

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ccf0c898b4c8
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.