589886 - services-sync modules should be app tiers, not platform

Status: RESOLVED DUPLICATE of bug 586867

(Firefox :: Sync, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Patch

Currently, services/sync and services/crypto are declared in toolkit/toolkit-tiers.mk. When building firefox as a xulrunner application, that means the modules are not included in xulrunner and sync doesn't work.

As it looks like all relevant parts of sync are in browser/, it does seem to make more sense to just declare them as app tiers instead of platform tiers. Maybe the services directory should also be moved under browser/, but that's another story.

Comment 1

[Mike Connor [:mconnor]]

Comment on attachment 468396 [details] [diff] [review]
Patch

bug 586867 is a different, and possibly better take on this.

This breaks Fennec, so r-, and I'm not convinced it's the right way to hook this up for arbitrary consumers.

/services is app-agnostic, so it certainly doesn't belong under /browser.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Different approach

Then the /services files should maybe be part of xulrunner. Benjamin, what do you think?

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #2)
> Then the /services files should maybe be part of xulrunner.

Judging from bug 581010 this is a WONTFIX.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 468410 [details] [diff] [review]
Different approach

That was marked WONTFIX in bug 581010 already.

Probably best to discuss before you keep throwing patches our way.