589910 - Notifications don't work in the sidebar

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[[e-mail]]

At some point, probably soon after we implemented notifications, since I know I would have tested it at the time, and it fails in an old 2.0pre/Gecko1.9.1pre build, the <browser> element got changed such that it now has a non-null docShell property even when it is hidden.

This means that notifications in the sidebar don't actually work :-(

Steps to reproduce problem:
javascript:sidebar.addPanel('Popup Test', 'http://www.popuptest.com/popuptest1.html', null);

Comment 1

[[e-mail]]

Attachment: Proposed patch

I also took the opportunity to move the button(s) between the icon and the close button. This often saves space in the common case, and I used an arrowscrollbox to stop the sidebar looking too bad in the multiple button case. Geolocation is a particularly bad example, try the following:

javascript:sidebar.addPanel("Demo: geolocation", "http://html5demos.com/geo", null);

(note that this "works" in the sidebar without the patch, because the geolocation notification code accesses the notificationbox directly.)

Comment 2

[Ian Neal]

Comment on attachment 468444 [details] [diff] [review]
Proposed patch

r=me

Comment 3

[[e-mail]]

Pushed changeset 262c8f5ec24d to comm-central.

Comment 4

[Robert Kaiser]

Comment on attachment 468444 [details] [diff] [review]
Proposed patch

I'm pretty sure we don't have any add-ons or such hooking into sidebar notifications, but else the <binding> change wouldn't be too good on a stable branch. In this case, I guess it's OK.

Comment 5

[Robert Kaiser]

Comment on attachment 468444 [details] [diff] [review]
Proposed patch

2.0.7 has been shipped, transferring approval to 2.0.8 instead.

Comment 6

[[e-mail]]

Pushed changeset e1bb865fb450 to releases/comm-1.9.1