589936 - Update maxVersion for 0.7 release

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

I posted about this on the google groups: http://groups.google.com/group/mozilla-labs-jetpack/browse_thread/thread/7be9ab97e71d776a/baf55642fe4b6085

Current maxVersion on install.rdf is 4.0b4pre, but beta 4 will be released soon. 

I think we should at least bump that to 4.0b5pre, or even greater if AMO rules allow that.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Currently AMO only allows up to 4.0b5pre, so I guess that's what it'll need to be for the moment.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Atul, I based this patch on your previous changeset: http://hg.mozilla.org/labs/jetpack-sdk/rev/af02bf6dcc0a

Is this the correct thing to do? Gecko maxVersion 4.0b4, FF app maxVersion 4.0b5pre

Comment 3

[Atul Varma [:atul]]

Comment on attachment 468521 [details] [diff] [review]
Patch

Yeah, looks good! (Except you made a typo in your comment, it should be Gecko maxVersion 2.0b4, but you didn't make that typo in the actual patch.)

Come to think of it, actually, since XULRunner apps containing application.ini are never sent to AMO, we actually have no pressing reason to constantly update the maxVersion in application.ini--we could probably just set it to 5.0 or something, or maybe 4.*, and as long as XULRunner doesn't complain when we run the app, we're golden...

Comment 4

[:Felipe Gomes (needinfo for replies!)]

(In reply to comment #3)
> Comment on attachment 468521 [details] [diff] [review]
> Patch
> 
> Yeah, looks good! (Except you made a typo in your comment, it should be Gecko
> maxVersion 2.0b4, but you didn't make that typo in the actual patch.)

Oops yes, typo in the comment.

myk: approval to land?

> 
> Come to think of it, actually, since XULRunner apps containing application.ini
> are never sent to AMO, we actually have no pressing reason to constantly update
> the maxVersion in application.ini--we could probably just set it to 5.0 or
> something, or maybe 4.*, and as long as XULRunner doesn't complain when we run
> the app, we're golden...

That is interesting. Yeah I think we should do that (after the tree reopens) and also think in a way to auto-update a released SDK with minor revision version bumps. Although this problem will go away _relatively_ soon after Firefox enters RC and drops the beta suffixes.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #4)
> myk: approval to land?

Granted!

Comment 6

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/labs/jetpack-sdk/rev/91db3981a6eb

Comment 7

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".