589961 - test-hidden-frame.testFrame failure on Firefox 3.6

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

I'm seeing a test failure in test-hidden-frame when run against Firefox 3.6:

error: TEST FAILED: test-hidden-frame.testFrame (failure)
error: fail: HiddenFrame loads about:blank by default. (null != "about:blank")
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/hidden-frame.js", line 153, in createElement
    errors.catchAndLog(function () handler.call(frame))();
  File "resource://jetpack-core-jetpack-core-lib/errors.js", line 49, in anonymous
    return callback.apply(this, arguments);
  File "resource://jetpack-core-jetpack-core-lib/hidden-frame.js", line 153, in anonymous
    errors.catchAndLog(function () handler.call(frame))();
  File "resource://jetpack-core-jetpack-core-tests/test-hidden-frame.js", line 9, in anonymous
    "HiddenFrame loads about:blank by default.");
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 231, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 149, in fail
    console.trace();

The problem doesn't occur on trunk nightly builds.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Taking, I know the fix for this.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Like page-worker, hidden-frame should wait to call onReady until DOMContentLoaded.

Comment 3

[Atul Varma [:atul]]

Comment on attachment 468525 [details] [diff] [review]
patch v1: fixes problem

Looks good. I assume that if the addon is unloaded between the time that the DOMContentLoaded listener is registered and when the event actually fires, nothing bad will happen? e.g., the parent window will just go away and the listener will never be triggered?

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #3)
> Comment on attachment 468525 [details] [diff] [review]
> patch v1: fixes problem
> 
> Looks good. I assume that if the addon is unloaded between the time that the
> DOMContentLoaded listener is registered and when the event actually fires,
> nothing bad will happen? e.g., the parent window will just go away and the
> listener will never be triggered?

Yes, that is entrained by the removal of the element from the window on unload.

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/37288479d249.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".