589965 - test-file.testDirName exceptions on trunk nightly

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

I'm seeing test failures in test-file when run against the latest trunk nightly:

error: TEST FAILED: test-file.testDirName (exception)
error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 58, in notify
    this._callback.apply(null, []);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 259, in 
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 284, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 302, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 57, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-file.js", line 14, in 
    var aDir = url.toFilename("resource://gre/modules/");
  File "resource://jetpack-core-jetpack-core-lib/url.js", line 93, in toFilename
    throw new Error("cannot map to filename: " + url);
  File "", line 0, in Error
Error: cannot map to filename: resource://gre/modules/
error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 58, in notify
    this._callback.apply(null, []);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 259, in 
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 284, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 302, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 57, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-file.js", line 26, in 
    var list = file.list(url.toFilename("resource://gre/modules/"));
  File "resource://jetpack-core-jetpack-core-lib/url.js", line 93, in toFilename
    throw new Error("cannot map to filename: " + url);
  File "", line 0, in Error
Error: cannot map to filename: resource://gre/modules/
..error: fail: file.read() on dir should raise error ("cannot map to filename: resource://gre/modules/" doesn't match /^path is not a file: .+$/)
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 58, in notify
    this._callback.apply(null, []);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 259, in anonymous
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 284, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 302, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 57, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-file.js", line 61, in anonymous
    "file.read() on dir should raise error"
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 190, in assertRaises
    this.assertMatches(errorMessage, predicate, message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 172, in assertMatches
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 149, in fail
    console.trace();
error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 58, in notify
    this._callback.apply(null, []);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 259, in 
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 284, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 302, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 57, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-file.js", line 66, in 
    var filename = url.toFilename("resource://gre/modules/XPCOMUtils.jsm");
  File "resource://jetpack-core-jetpack-core-lib/url.js", line 93, in toFilename
    throw new Error("cannot map to filename: " + url);
  File "", line 0, in Error
Error: cannot map to filename: resource://gre/modules/XPCOMUtils.jsm
.............................................................................................................................................................................................................................................................................................................................................................................................................................error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 58, in notify
    this._callback.apply(null, []);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 259, in 
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 284, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 302, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 57, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-url.js", line 65, in 
    test.assertMatches(url.toFilename("resource://gre/modules/"),
  File "resource://jetpack-core-jetpack-core-lib/url.js", line 93, in toFilename
    throw new Error("cannot map to filename: " + url);
  File "", line 0, in Error
Error: cannot map to filename: resource://gre/modules/
...........................................................................................................................................................................................................................................

Comment 1

[Atul Varma [:atul]]

Attachment: patch

Comment 2

[Atul Varma [:atul]]

Comment on attachment 468515 [details] [diff] [review]
patch

I think this is dying on nightlies because of the omnijar stuff, whereby lots of stuff that used to be on the filesystem is now in a JAR file. These tests were expecting some things, totally coincidentally, to on the local filesystem rather than in jars.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 468515 [details] [diff] [review]
patch

Looks good, works well. r=myk!

Comment 4

[Atul Varma [:atul]]

O yea, pushed!

Bug 589965 - test-file.testDirName exceptions on trunk nightly
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/01e59b9e7cbe

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".