590033 - Error in nsIAutoCompletePopup::invalidate (Again)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Bug 575477 tried to fix this bug, but failed.

Exception... "'[JavaScript Error: "title.match(/^(.+) \u2013 (.+)$/) is null"
{file: "chrome://browser/content/bindings.xml" line: 259}]' when calling
method: [nsIAutoCompletePopup::invalidate]"  nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame ::
file:///home/mfinkle/Source/mozilla-trunk/mobile-debug/dist/bin/components/AutoCompleteCache.js
:: anonymous :: line 249"  data: yes

I found a title like " - Bookmarks Menu" would cause the error. The regex tries to split on the " - " and has nothing for title, so I guess it throws. This patch silences the throw. The error actually causes the "Show all bookmarks" to not be displayed, as well as some other oddities.

I have no idea how such a title got into my history.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/b13137a67097

Comment 2

[Dão Gottwald [:dao]]

bugspam

Comment 3

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110919
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2