fix cross-architecture pointer size serialization problem with Cocoa NPAPI events

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
x86_64
macOS
Points:
---

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The Cocoa NPAPI event structure contains pointers which will be of different sizes on i386 and x86_64. This means message size expectations will not match when sending an event from an x86_64 parent to an i386 child.
(Assignee)

Updated

9 years ago
Blocks: 559142
(Assignee)

Comment 1

9 years ago
Posted patch fix v1.0Splinter Review
(Assignee)

Updated

9 years ago
Attachment #468909 - Flags: review?(b56girard)
(Assignee)

Updated

9 years ago
Attachment #468909 - Flags: review?(jones.chris.g)
Comment on attachment 468909 [details] [diff] [review]
fix v1.0

r=me for the chromium stuff, didn't look at the NPEvent changes.
Attachment #468909 - Flags: review?(jones.chris.g) → review+
Comment on attachment 468909 [details] [diff] [review]
fix v1.0

r+ on the NPCocoaEvent changes.
Attachment #468909 - Flags: review?(b56girard) → review+
(Assignee)

Updated

9 years ago
blocking2.0: --- → beta6+
(Assignee)

Comment 4

9 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/6f2fd17d789a
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.