590090 - Write a CSS selector parser for the new Style panel

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Mihai Sucan [:msucan]]

Currently we take each rule and we do rule.selectorText.split(",") to walk through each simple selector. This fails with selectors like:

h2, :-moz-any(article, aside, nav, section) h1 {
  display: block;
  font-size: 1.5em;
  font-weight: bold;
  margin: .83em 0;
}

... found in resource://gre-resources/html.css.

We need to properly parse selectors and build an array of simple selectors - perhaps even a nested array of selectors.

Comment 1

[Mihai Sucan [:msucan]]

This is now fixed in bug 585565. We can mark this as FIXED or a DUPLICATE.

Comment 2

[Joe Walker [:jwalker]]

We need to check that this patch takes into account "E ~ F" and nasty cases like E[foo~="bar"]

Comment 3

[Joe Walker [:jwalker]]

Should we leave this open to catch the E[foo~="bar"] case?

Comment 4

[Mihai Sucan [:msucan]]

Yeah, sure. We can consider this bug as part of the wider needs of selectors parsing we have.

Bug 585565 includes its minimal code for making it work fine with UA stylesheets. When we get time to implement the selector parsing for specificity, then we can mark this as fixed.

Comment 5

[Joe Walker [:jwalker]]

http://www.w3.org/TR/css3-selectors/#grammar says we don't need to worry about the whole ~ issue.

It also defines "a, b" to be a selector_group and not a selector ;-)

So in short since "a ~ b" is a selector and not a selector_group, then our current parser implementation is good, and we can close this bug.

Disagreement?

Comment 6

[Joe Walker [:jwalker]]

The partial issue left over here is covered in Bug 592743. Closing this bug.