590101 - reftest failures using harfbuzz font backend on windows

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

When using the harfbuzz font backend on windows, there are a few reftests that fail:

(1) text/wordwrap-03 - Fails because the test relies on the use of combining diacritics but does not guarantee that the (monospace) font chosen actually supports them, so results depend on how the font shaping engine handles this.

(2) font-features tests (several failures) - (a) The use of ZWNJ in the turkish-ref file disturbs default line spacing, because fallback chooses a font with different line metrics. (b) When DWrite is enabled, we also get a one-pixel discrepancy in gray levels where the glyphs "f" and "i" touch at a text-run boundary.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: patch, part 1 - fix text/wordwrap-03 reftest to use font with support for diacritics

This fixes the text/wordwrap-03 reftest for windows+harfbuzz by ensuring that we use a font with adequate diacritic-positioning support (Consolas on Win7; DejaVu Sans Mono otherwise, via @font-face).

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: patch, part 2 - make font-features reftests more robust

This fixes the font-features reftests for windows+harfbuzz by (a) setting a larger line-height, so that font fallback on the ZWNJ character doesn't perturb line spacing; and (b) enlarging the font to avoid a discrepancy that occurs under DWrite/D2D where the antialiasing of glyphs "f" and "i" in separate text-runs overlap each other by one pixel at the original size.

Comment 3

[Jonathan Kew [:jfkthame]]

Part 1: http://hg.mozilla.org/mozilla-central/rev/3b14081dae0b
Part 2: http://hg.mozilla.org/mozilla-central/rev/1afaed8bf727

Comment 4

[Jonathan Kew [:jfkthame]]

With gfx.font_rendering.harfbuzz.level=1, all tests now pass on tryserver under Win2003.

On Win7, there are three remaining failures:

REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/tryserver_win7_test-reftest/build/reftest/tests/layout/reftests/bidi/267459-1.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/tryserver_win7_test-reftest/build/reftest/tests/layout/reftests/bidi/305643-1.html |
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/tryserver_win7_test-reftest/build/reftest/tests/layout/reftests/svg/text-gradient-02.svg |

The first two are minor (subpixel) glyph rendering discrepancies between text drawn LTR and RTL; the third is imperceptible to my eyes but is apparently a difference in a gradient.

Comment 5

[Jonathan Kew [:jfkthame]]

Pushed a followup to mark the font-features-turkish tests as random on windows due to tinderbox orange:
http://hg.mozilla.org/mozilla-central/rev/e3fe95511fc2

I think this depends on the windows/uniscribe version, but the test is basically meaningless until we flip on the harfbuzz pref. At that point a number of the font-features-* tests will become useful there as well.

Comment 6

[Jonathan Kew [:jfkthame]]

Resolving this, as there's nothing left to do here; we've turned on harfbuzz and reftests are passing happily on all our Windows platforms.