590119 - AMO Editors: Misc Errors causing XPI install failure

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Brian King [:kinger]]

Mozilla/5.0 (Windows NT 6.0; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre (.NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729)

Sometimes when I try to install an XPI from the Editor's control panel, e.g.

https://addons.mozilla.org/en-US/editors/review/116044
which provides a direct link to:
https://addons.mozilla.org/en-US/firefox/downloads/file/97348/copy_shorturl-1.2-fx+fn+tb.xpi

... the install fails. The install dialog fails to appear.

Some Error console output:

Error: too much recursion

Error: too much recursion
Source File: chrome://mozapps/content/extensions/extensions.xml
Line: 205

Error: this._progress is undefined
Source File: chrome://mozapps/content/extensions/extensions.xml
Line: 205

Error: too much recursion
Source File: resource://gre/modules/XPIProvider.jsm
Line: 4921Error: too much recursion
Source File: resource://gre/modules/XPIProvider.jsm
Line: 4921

Error: ERROR addons.manager: Exception calling provider.getInstallForURL: InternalError: too much recursion

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Does it also happen for other sandboxed extensions? I can't test it because I'm not an editor.

Comment 2

[Brian King [:kinger]]

(In reply to comment #1)
> Does it also happen for other sandboxed extensions? I can't test it because I'm
> not an editor.

No.

And I can't reproduce in the latest build:

Mozilla/5.0 (Windows NT 6.0; rv:2.0b5pre) Gecko/20100824 Minefield/4.0b5pre (.NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729)

Instead, at:

https://addons.mozilla.org/en-US/editors/review/116075

... I get a different error.

Warning: WARN addons.manager: Failure calling web installer: [Exception... "'[JavaScript Error: "too much recursion" {file: "resource://gre/modules/AddonManager.jsm" line: 283}]' when calling method: [amIWebInstallListener::onWebInstallRequested]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: resource://gre/modules/AddonManager.jsm :: AMI_installAddonsFromWebpage :: line 533"  data: yes]

Warning: WARN addons.manager: Exception calling callback: TypeError: this.channel is undefined

cc'ing Jorge and Justin who may be able to give you access to test this.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Brian, can you reproduce the bug at https://addons.mozilla.org/en-US/firefox/addon/52369/versions/ ? That would be easier for Henrik to test with.

FWIW, I couldn't reproduce in b4.
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b4) Gecko/20100818 Firefox/4.0b4

Comment 4

[Brian King [:kinger]]

I only see this bug on one profile that I can not test until tomorrow. More followup to come then...

Comment 5

[Brian King [:kinger]]

(In reply to comment #3)
> Brian, can you reproduce the bug at
> https://addons.mozilla.org/en-US/firefox/addon/52369/versions/ ? That would be
> easier for Henrik to test with.

For an up-to-date add-on, I can not reproduce on the following page:

https://addons.mozilla.org/en-US/firefox/addon/26/versions/

Mozilla/5.0 (Windows NT 6.0; rv:2.0b6pre) Gecko/20100907 Firefox/4.0b6pre

Comment 6

[Andy McKay]

Closing based on comment 5 and 7 years of inactivity.