If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

crash [@nsAccessible::GetIndexOf]

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: davidb, Assigned: surkov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We're getting a few strange crash stacks on Linux (4.0b5pre).

SEGV at 0x20 (which happens to be hex for a whitespace " ").

Top of stack:
0  	libxul.so  	nsAccessible::GetIndexOf  	 accessible/src/base/nsAccessible.cpp:2881
1 		@0xa5a5e94f 	
2 	libxul.so 	nsAccessible::GetIndexOfEmbeddedChild 	accessible/src/base/nsAccessible.cpp:2936
3 	libxul.so 	nsHyperTextAccessible::GetLinkIndexAtOffset 	accessible/src/html/nsHyperTextAccessible.h:125
4 	libxul.so 	getLinkIndexCB 	accessible/src/atk/nsMaiInterfaceHypertext.cpp:102
5 	libatk-1.0.so.0.3009.1 	libatk-1.0.so.0.3009.1@0xa4ba

(from: http://crash-stats.mozilla.com/report/index/cb849347-5333-40a0-9e2b-3c26b2100818)
(Assignee)

Comment 1

7 years ago
At the first glance it looks like a missing null-check.
(Assignee)

Comment 2

7 years ago
Created attachment 468713 [details] [diff] [review]
patch

GetLinkIndexAtOffset is used without proper checks on platform specific part. Add a check to it rather than to GetIndexOf.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #468713 - Flags: review?(bolterbugz)
Attachment #468713 - Flags: approval2.0?
Comment on attachment 468713 [details] [diff] [review]
patch

Looks good a+r=me :)
Attachment #468713 - Flags: review?(bolterbugz)
Attachment #468713 - Flags: review+
Attachment #468713 - Flags: approval2.0?
Attachment #468713 - Flags: approval2.0+
(Assignee)

Comment 4

7 years ago
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/55f009ed5368
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.