Closed
Bug 590128
Opened 14 years ago
Closed 14 years ago
crash [@nsAccessible::GetIndexOf]
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: davidb, Assigned: surkov)
Details
Attachments
(1 file)
|
800 bytes,
patch
|
davidb
:
review+
davidb
:
approval2.0+
|
Details | Diff | Splinter Review |
We're getting a few strange crash stacks on Linux (4.0b5pre). SEGV at 0x20 (which happens to be hex for a whitespace " "). Top of stack: 0 libxul.so nsAccessible::GetIndexOf accessible/src/base/nsAccessible.cpp:2881 1 @0xa5a5e94f 2 libxul.so nsAccessible::GetIndexOfEmbeddedChild accessible/src/base/nsAccessible.cpp:2936 3 libxul.so nsHyperTextAccessible::GetLinkIndexAtOffset accessible/src/html/nsHyperTextAccessible.h:125 4 libxul.so getLinkIndexCB accessible/src/atk/nsMaiInterfaceHypertext.cpp:102 5 libatk-1.0.so.0.3009.1 libatk-1.0.so.0.3009.1@0xa4ba (from: http://crash-stats.mozilla.com/report/index/cb849347-5333-40a0-9e2b-3c26b2100818)
|
Assignee | |
Comment 1•14 years ago
|
||
At the first glance it looks like a missing null-check.
|
|
Assignee | |
Comment 2•14 years ago
|
||
GetLinkIndexAtOffset is used without proper checks on platform specific part. Add a check to it rather than to GetIndexOf.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #468713 -
Flags: review?(bolterbugz)
Attachment #468713 -
Flags: approval2.0?
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 468713 [details] [diff] [review] patch Looks good a+r=me :)
Attachment #468713 -
Flags: review?(bolterbugz)
Attachment #468713 -
Flags: review+
Attachment #468713 -
Flags: approval2.0?
Attachment #468713 -
Flags: approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/55f009ed5368
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•