590229 - Fallback updates are not downloaded - infinite spinning while trying to connect to update server

Status: RESOLVED DUPLICATE of bug 576939

(Toolkit :: Application Update, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.9pre) Gecko/20100801 Namoroka/3.6.9pre

Today I was running some update paths for the back port work of our Mozmill tests and whatever build from the 1.9.2 I use, it ends up in an infinite loop while connection to the update server. 

Steps:
1. Install a nightly build which will require a complete update
2. Download the update but do not restart Firefox
3. Close Firefox and invalidate the update
4. Start Firefox again
5. Click next in the error patching dialog

After step 5 Firefox tries to connect to the update server but no connection can be established. We hang forever at this point.

A similar behavior has been reported by others for Firefox 4.0 Beta 4. Marcia and Juan can probably give more information.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I did some more investigation here and run a couple more nightly builds and nailed down it down to 100803 - 100805. Sadly there is no Mac nightly for 100804. But the 100805 build works just fine.

That exactly fits into the range when the backport patch for the software update fixes (bug 576939) has been landed on 1.9.2.

I would assume we have a regression here and it will also block our fallback updates for 3.6.8 -> 3.6.9.

Comment 2

[[e-mail] (:bhearsum)]

Have you looked for recent client side updater changes? I seriously doubt this an issue with infrastructure.

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #0)
> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.9pre)
> Gecko/20100801 Namoroka/3.6.9pre
> 
> Today I was running some update paths for the back port work of our Mozmill
> tests and whatever build from the 1.9.2 I use, it ends up in an infinite loop
> while connection to the update server. 
> 
> Steps:
> 1. Install a nightly build which will require a complete update
> 2. Download the update but do not restart Firefox
> 3. Close Firefox and invalidate the update
> 4. Start Firefox again
> 5. Click next in the error patching dialog
> 
> After step 5 Firefox tries to connect to the update server but no connection
> can be established. We hang forever at this point.
> 
> A similar behavior has been reported by others for Firefox 4.0 Beta 4. Marcia
> and Juan can probably give more information.
The similar problem isn't similar at all. It was due to an incorrect update snippet unless this is about an invalid snippet which I am quite sure it isn't.

Moving over to app update.

Henrik, specifically how did you invalidate the update?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #3)
> Henrik, specifically how did you invalidate the update?

This time the right way as how we do it with Mozmill. I have changed "pending\n" to "failed: 6\n" in the update.status file.

Comment 5

[[e-mail] (:bhearsum)]

Have you tested outside of Mozmill?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #5)
> Have you tested outside of Mozmill?

Yes, for the complete regression test run.

Comment 7

[Robert Strong (they/them - no direct email)]

I...

downloaded nightly 3.6.9pre that only has a complete update
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010-08-21-05-mozilla-1.9.2/
downloaded the complete update
exited Firefox
modified update.status so the first line contained "failed: 6"
started Firefox

The ui displayed was "The update could not be installed (patch apply failed)" error page with a link to update by downloading the lastest version and no option to download the update using app update (e.g. clicking ok closes the ui).

Henrik, which "nightly build" did you download to test with?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Use the one as mentioned in comment 1 from 100803:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010/08/2010-08-03-03-mozilla-1.9.2/firefox-3.6.9pre.en-US.mac.dmg

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That means all builds before the landing are affected and not the builds after.

Comment 10

[[e-mail] (:bhearsum)]

Of note is that bug 576939 did not land until after the build you pasted (landed at: Tue Aug 03 12:50:14 2010 -0700)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, the same can be seen for 1.9.1 builds. As Rob mentioned bug 576939 fixes this particular issue so updates without a partial are not stuck. So we are good to go for 3.6.9. Sorry for the noise.