590366 - [D3D9] Clear retained area when creating a new texture

Status: RESOLVED DUPLICATE of bug 592024

(Core :: Graphics, defect)

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Clearing!

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 468872 [details] [diff] [review]
Clearing!

>From: Matt Woodrow <[e-mail]>
>
>diff --git a/gfx/layers/d3d9/ThebesLayerD3D9.cpp b/gfx/layers/d3d9/ThebesLayerD3D9.cpp
>--- a/gfx/layers/d3d9/ThebesLayerD3D9.cpp
>+++ b/gfx/layers/d3d9/ThebesLayerD3D9.cpp
>@@ -450,6 +455,8 @@ ThebesLayerD3D9::CreateNewTexture(const 
>                             D3DUSAGE_RENDERTARGET, UseOpaqueSurface(this) ? D3DFMT_X8R8G8B8 : D3DFMT_A8R8G8B8,
>                             D3DPOOL_DEFAULT, getter_AddRefs(mTexture), NULL);
>   }
>+
>+  mValidRegion = nsIntRegion();
> }
> 
> } /* namespace layers */
mValidRegion.SetEmpty() is better.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Fixed review comment

We're clearing the retained texture on scrolling because the visible region changes.

I could look at copying valid content from the old texture across and/or keeping a retained texture larger than the current visible region if you think that's worthwhile.

Comment 4

[Matt Woodrow (:mattwoodrow)]

On further looking, clearing the mValidRegion isn't a great solution because it means we redraw the entire ThebesLayer contents when scrolling.

This bug appears to be intermittent and only when using d2d surfaces.

I copied the contents of mD2DSurface to an image surface before and after StretchRect (inside SetValidRegion) and it appeared to be copying all black to the new texture.

Might be a driver related issue of some sort? I'd suggest landing this patch for the time being (especially if anyone else can reproduce the problem) and look into it further before release.

Comment 5

[Matt Woodrow (:mattwoodrow)]

This will be fixed by bug 592024