Closed Bug 590390 Opened 10 years ago Closed 9 years ago

DeCOM nsICharsetAlias

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This interface should be simple C-style helper function.
Attached patch for m-c (obsolete) — Splinter Review
Assignee: smontagu → m_kato
So, what's this patch waiting for?
(In reply to comment #2)
> So, what's this patch waiting for?

Since this causes API break, after 2.0 branching, I will set a review flag.
A reviewer is needed for this patch.
Comment on attachment 468907 [details] [diff] [review]
for m-c

Indeed, 2.0 has shipped for a couple of days now. Simon?
Attachment #468907 - Flags: review?(smontagu)
Comment on attachment 468907 [details] [diff] [review]
for m-c

The patch is bitrotted, not surprisingly after all this time, but it looks good in principal. I would love to review an updated version.
Attachment #468907 - Flags: review?(smontagu) → review-
Depends on: 719304
Attached patch fix v2Splinter Review
Attachment #468907 - Attachment is obsolete: true
Attachment #600309 - Flags: review?(smontagu)
Comment on attachment 600309 [details] [diff] [review]
fix v2

Review of attachment 600309 [details] [diff] [review]:
-----------------------------------------------------------------

Nice
Attachment #600309 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/2893c5e0be5d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Depends on: 737966
This caused bug 737966. Kato-san, could you attach a fix there.
You need to log in before you can comment on or make changes to this bug.