DeCOM nsICharsetAlias

RESOLVED FIXED in mozilla13

Status

()

Core
Internationalization
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

53.23 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
This interface should be simple C-style helper function.
(Assignee)

Comment 1

7 years ago
Created attachment 468907 [details] [diff] [review]
for m-c
Assignee: smontagu → m_kato
So, what's this patch waiting for?
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> So, what's this patch waiting for?

Since this causes API break, after 2.0 branching, I will set a review flag.
A reviewer is needed for this patch.
Comment on attachment 468907 [details] [diff] [review]
for m-c

Indeed, 2.0 has shipped for a couple of days now. Simon?
Attachment #468907 - Flags: review?(smontagu)
Comment on attachment 468907 [details] [diff] [review]
for m-c

The patch is bitrotted, not surprisingly after all this time, but it looks good in principal. I would love to review an updated version.
Attachment #468907 - Flags: review?(smontagu) → review-
(Assignee)

Updated

5 years ago
Depends on: 719304
(Assignee)

Comment 7

5 years ago
Created attachment 600309 [details] [diff] [review]
fix v2
Attachment #468907 - Attachment is obsolete: true
Attachment #600309 - Flags: review?(smontagu)
Comment on attachment 600309 [details] [diff] [review]
fix v2

Review of attachment 600309 [details] [diff] [review]:
-----------------------------------------------------------------

Nice
Attachment #600309 - Flags: review?(smontagu) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2893c5e0be5d
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/2893c5e0be5d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla13
Depends on: 737966
This caused bug 737966. Kato-san, could you attach a fix there.
You need to log in before you can comment on or make changes to this bug.