Last Comment Bug 590390 - DeCOM nsICharsetAlias
: DeCOM nsICharsetAlias
Product: Core
Classification: Components
Component: Internationalization (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla13
Assigned To: Makoto Kato [:m_kato]
: Makoto Kato [:m_kato]
Depends on: 719304 737966
Blocks: deCOM
  Show dependency treegraph
Reported: 2010-08-24 19:47 PDT by Makoto Kato [:m_kato]
Modified: 2012-03-26 17:14 PDT (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

for m-c (52.02 KB, patch)
2010-08-24 19:48 PDT, Makoto Kato [:m_kato]
smontagu: review-
Details | Diff | Splinter Review
fix v2 (53.23 KB, patch)
2012-02-23 22:13 PST, Makoto Kato [:m_kato]
smontagu: review+
Details | Diff | Splinter Review

Description User image Makoto Kato [:m_kato] 2010-08-24 19:47:58 PDT
This interface should be simple C-style helper function.
Comment 1 User image Makoto Kato [:m_kato] 2010-08-24 19:48:54 PDT
Created attachment 468907 [details] [diff] [review]
for m-c
Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2011-01-04 12:02:49 PST
So, what's this patch waiting for?
Comment 3 User image Makoto Kato [:m_kato] 2011-01-04 17:12:13 PST
(In reply to comment #2)
> So, what's this patch waiting for?

Since this causes API break, after 2.0 branching, I will set a review flag.
Comment 4 User image Marco Castelluccio [:marco] 2011-07-22 11:43:41 PDT
A reviewer is needed for this patch.
Comment 5 User image :Ms2ger (⌚ UTC+1/+2) 2011-07-22 12:51:48 PDT
Comment on attachment 468907 [details] [diff] [review]
for m-c

Indeed, 2.0 has shipped for a couple of days now. Simon?
Comment 6 User image Simon Montagu :smontagu 2011-07-23 22:37:51 PDT
Comment on attachment 468907 [details] [diff] [review]
for m-c

The patch is bitrotted, not surprisingly after all this time, but it looks good in principal. I would love to review an updated version.
Comment 7 User image Makoto Kato [:m_kato] 2012-02-23 22:13:43 PST
Created attachment 600309 [details] [diff] [review]
fix v2
Comment 8 User image Simon Montagu :smontagu 2012-02-28 08:47:12 PST
Comment on attachment 600309 [details] [diff] [review]
fix v2

Review of attachment 600309 [details] [diff] [review]:

Comment 10 User image Matt Brubeck (:mbrubeck) 2012-03-05 13:29:22 PST
Comment 11 User image Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-03-26 17:14:25 PDT
This caused bug 737966. Kato-san, could you attach a fix there.

Note You need to log in before you can comment on or make changes to this bug.