590511 - Removing Jetpacks under the Recent Updates pane doesn't work

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100825 Minefield/4.0b5pre

If you open the Recent Updates pane of the add-ons manager and click the x button to remove an installed Jetpack, it is marked as removed in that pane. But when you select the extension pane, the Jetpack is back. Looks like we do not write the correct values into the database? It works fine for old style extensions.

Steps:
1. Install a Jetpack like: https://secure.toolness.com/xpi/facebook-acquaintances.xpi
2. Select "View Recent Updates"
3. Remove the Facebook Jetpack
4. Open the Extension pane

After step 4 the Facebook Jetpack is back while it should be marked as removed.

Comment 1

[Drew Willcoxon :adw]

Huh, I wonder if this is relevant:

  1369  // This won't update any other add-on manager views (bug 582002)
  1370  this.setAttribute("pending", "uninstall");

http://hg.mozilla.org/mozilla-central/file/78df45be19d1/toolkit/mozapps/extensions/content/extensions.xml#l1369

Comment 2

[Drew Willcoxon :adw]

Dave, is bug 582002 related to this?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> Dave, is bug 582002 related to this?

No, I suspect all you need to do is copy from the code here to the hide method on gUpdatesView.

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#1675

Comment 4

[Drew Willcoxon :adw]

Attachment: patch

Oh great, thanks Dave.  It does seem to work.

Comment 5

[Drew Willcoxon :adw]

http://hg.mozilla.org/mozilla-central/rev/1bad85a23cc5

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101212 Firefox/4.0b8pre

Can we get an automated test for it?