590517 - Add "Open in New Tab" menu item to Awesome Screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Irina Sandu]

This is a bug to add "Open in New Tab" menu item in the context menu of the Awesome Screen items.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Agreed

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I also want to add more items to the (future) context menu of the awesome panel (like "Forget this domain" or "Share")

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The attached patch add "Open In New Tab" and "Share Link" as context items.
The awesome panel is not closed when we open a new tab (I have a doubt on the right behavior here, I've moved the "new tab popup" to be above the awesome panel to have a feedback)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 469487 [details] [diff] [review]
Patch

Patch looks OK, but I think we'll want to close the awesomescreen when opening a new tab. Sharing and editing (for bookmarks) sound like good cases for leaving the awesomscreen open.

Madhava -  thoughts?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch add a small fix found while testing.

For the case where we want or not to close the Awesome Panel I've tried to do it but since "Open In New Tab" does not put the tab into the foreground this give a strange effect.

The website menu is not doing it too (moving the tab to the foreground) since this is the same code path.
(But) I realize that the expectation are probably different when doing this on a website or searching into the Awesome Panel.

Irina, what are doing the other browsers?

Comment 6

[Madhava Enros [:madhava]]

Vivien - adding a "Forget this Page" or "Forget this Site" would be a really useful thing.

For this one - open in new tab - what is the anticipated use-case for doing this from the awesomescreen?  A user taps on the title to go somewhere and, on the way to finding the thing he or she wants, notices something else that he or she would like to see later?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #6)

> For this one - open in new tab - what is the anticipated use-case for doing
> this from the awesomescreen?  A user taps on the title to go somewhere and, on
> the way to finding the thing he or she wants, notices something else that he or
> she would like to see later?

The user realizes that he does not want to clobber the existing tab content, iirc.

Comment 8

[Irina Sandu]

I do that when I am in the middle of reading an article but that reminds me of something I want to check after finishing reading and I open a new tab in the background in order not to forget.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

What's wrong with the current flow of opening a new tab (which opens the awesome screen) loading your new page and then returning to the original tab?

Comment 10

[Matt Brubeck (:mbrubeck)]

(In reply to comment #9)
> What's wrong with the current flow of opening a new tab (which opens the
> awesome screen) loading your new page and then returning to the original tab?

You might change your mind.  Also, opening the awesomescreen directly (by pressing the Android "Search" button, or tapping the urlbar if it is visible) is often more convenient than panning to show the new tab button - especially if you are zoomed in and might need to pan a lot.

Comment 11

[Madhava Enros [:madhava]]

for the question raised in an etherpad - we shouldn't close the awesomescreen after a user opens something in a new tab.  This mirrors the behavior of opening a link in a new tab, which leaves the user where he or she is.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 469705 [details] [diff] [review]
Patch

Looking at Madhava's comment the behavior in this patch should be good. I'm asking review again because of the small changes and to ensure I have well understood the comment :)

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 469705 [details] [diff] [review]
Patch

Seems like you have the design as Madhava wanted

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/4ac74951887d

Comment 15

[Ayan Shah[:ashah]]

Verified on :

Build: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b6pre)Gecko/20100909
Firefox/4.0b6pre Fennec /2.0b1pre