590519 - Compile failure on ARM - "'rdtsc' was not declared in this scope"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

A js shell fails to compile on TM changeset http://hg.mozilla.org/tracemonkey/rev/dc01b8dbb58a

===

jsatom.cpp
jsbool.cpp
jscntxt.cpp
jsdate.cpp
jsdbgapi.cpp
jsdhash.cpp
jsdtoa.cpp
jsemit.cpp
jsexn.cpp
jsfun.cpp
jsgc.cpp
../jsgc.cpp:1151:1: warning: "CMP" redefined
In file included from ../nanojit/Native.h:60,
                 from ../nanojit/nanojit.h:368,
                 from ../jsbuiltins.h:45,
                 from ../jstracer.h:48,
                 from ../jsgc.cpp:82:
../nanojit/NativeARM.h:529:1: warning: this is the location of the previous definition
../jsgc.cpp: In function 'void GC(JSContext*, js::GCTimer&)':
../jsgc.cpp:2727: error: 'rdtsc' was not declared in this scope
../jsgc.cpp: In function 'void GCUntilDone(JSContext*, JSGCInvocationKind, js::GCTimer&)':
../jsgc.cpp:3042: error: 'rdtsc' was not declared in this scope
make[1]: *** [jsgc.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [default] Error 2

Comment 1

[Jacob Bramley [:jbramley]]

Problem seems to be caused by bug 589262, though that's by observation rather than by a proper test. (Pressed for time at the moment.)

Comment 2

[Gregor Wagner [:gwagner]]

Yes it is definitely caused by bug 589262. I thought that issue was fixed with bug 555338. I will remove the GCTIMER by default for debug builds again.

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 4

[Gregor Wagner [:gwagner]]

Gary or Jacob, could you try this patch? I don't have access to an arm environment.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #3)
> Created attachment 469070 [details] [diff] [review]
> patch

Yup, this patch seems to re-enable builds again. No longer busting with this patch.

Comment 6

[Gregor Wagner [:gwagner]]

http://hg.mozilla.org/tracemonkey/rev/e81fa1f189dc

Comment 7

[Karsten Düsterloh]

I see this also for PPC debug builds on trunk. Can't await it landing there. ;-)

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/e81fa1f189dc