590575 - Deselecting optional components in SeaMonkey installer does not work

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Peter B. Shalimoff]

User-Agent:       Mozilla/5.0 (Windows NT 5.2; rv:2.0b4pre) Gecko/20100817 SeaMonkey/2.1a3
Build Identifier: Mozilla/5.0 (Windows NT 5.2; rv:2.0b4pre) Gecko/20100817 SeaMonkey/2.1a3

Installer ignores custom installation options and installs Chatzilla whether its checkbox is checked or not.

Reproducible: Always

Steps to Reproduce:
1. Start the installer.
2. Select Custom installation type.
3. Uncheck the "Chatzilla" checkbox.

Actual Results:  
Chatzilla is installed.


Expected Results:  
Chatzilla must not be installed.

Comment 1

[Bruno 'Aqualon' Escherl]

CCing Frank, he should know most about the installer.

Comment 2

[Frank Wein [:mcsmurf]]

This could be fall-out from Bug 556644, the core\ folder in the installer also includes the extensions\ folder. Normally only the optional\ folder should include the extensions\ folder (as all the extensions can be unchecked when using the custom installation mode). Everything in the core\ folder gets copied to SeaMonkey program folder so that is why deselecting components no longer works.

Comment 3

[Michael Wu [:mwu]]

Attachment: Untested patch

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 471209 [details] [diff] [review]
Untested patch

Patch seems to work fine, I tested it by creating a SeaMonkey installer and deselecting optional components. I also checked the temporary folder into which the installer files get extracted to, the core\extensions\ folder only contains the SeaMonkey themes, which are not optional components.

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch

Actually Attachment 471209 [details] [diff] did not work fine, I forgot to test running SeaMonkey itself..
Here is a new approach: This one removes all files from installer-stage/core/ which are also present in installer-stage/optional/.

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: Patch

This one is better, it avoids the warning because of the dot directory that cannot be removed (as the first line in the find output with the old patch was "." for the current directory).

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 480418 [details] [diff] [review]
Patch

r=me

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Fwiw, I think this qualifies as NPOTB because Firefox has no optional components.  Please test it on try though to make sure it doesn't blow anything up.

Comment 9

[Frank Wein [:mcsmurf]]

Pushed to try, worked fine, then pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/1951afcefd05