Closed Bug 590599 Opened 14 years ago Closed 14 years ago

change layers acceleration prefs

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: joe, Assigned: joe)

References

Details

Attachments

(1 file, 1 obsolete file)

This patch does a couple of things:
1. It renames the mozilla.widget.accelerate-layers and mozilla.layers.prefer-opengl prefs to layers.accelerate and layers.prefer-opengl, respectively.
2. It changes layers.accelerate to be the default value, rather than an override. If layers.accelerate is false, layers can still be accelerated if they have the accelerated attribute. (There is currently no way for a window to disable acceleration if the user has it turned on.)
2. It adds layers.disable-acceleration to allow users to disable all acceleration, regardless of whether a window has the accelerated attribute.

The net of this is that we can turn on layers acceleration by setting layers.accelerate to true (rather than setting MOZ_ACCELERATE to 1 in the environment).
Attachment #469105 - Flags: review?(roc)
layers.disable-acceleration and layers.accelerate sound really similar; on initial look I'd think they were inverses. Instead of just layers.accelerate, might I suggest layers.accelerate-by-default or layers.accelerate-everything or something to be more precise in its meaning?
How about a tri-state? layers.acceleration: 0 -> everything disabled, 1 -> enabled on opt-in chrome documents, 2 -> enabled on everything
It's kind of ugly having an integer instead of booleans, though. You have to remember what value means what rather than self-explanatory names and true/false values.
Yes, but it's less confusing than two boolean prefs that sound redundant.
Well then, we should just name them differently.

layers.gpu-accelerate-by-default
layers.disable-all-gpu-acceleration
how about layers.accelerate-none and layers.accelerate-all?
Assignee: nobody → joe
Attachment #469105 - Attachment is obsolete: true
Attachment #469979 - Flags: review?(roc)
Attachment #469105 - Flags: review?(roc)
blocking2.0: --- → beta6+
http://hg.mozilla.org/mozilla-central/rev/3198333dc766
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 593898
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: