590621 - Console panels feature a confusing control

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Kevin Dangoor]

Attachment: Screenshot of the offending control

When you open a panel in the console (such as the property viewer) it has a confusing control that does not have any labeling and doesn't seem to do anything useful. This should be eliminated.

(Worst case scenario would be adding a string to at least have a label next to the checkbox, but much better is for the control to go away)

Comment 1

[Kevin Dangoor]

Reprioritizing bugs. You can filter the mail on the word TEABAGS.

Comment 2

[Joe Walker [:jwalker]]

Attachment: [checked-in] Upload 1

This comes down to:

   // Create the tree.
-  let tree = this.tree = createElement(aDocument, "tree", { flex: 1 });
+  let tree = this.tree = createElement(aDocument, "tree", {
+    flex: 1,
+    hidecolumnpicker: "true"
+  });
 
   let treecols = aDocument.createElement("treecols");
   appendChild(aDocument, treecols, "treecol", {
     primary: "true",
-    flex: 1
+    flex: 1,
+    hideheader: "true",
+    ignoreincolumnpicker: "true"
   });
   tree.appendChild(treecols);

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 474669 [details] [diff] [review]
[checked-in] Upload 1

>diff --git a/toolkit/components/console/hudservice/PropertyPanel.jsm b/toolkit/components/console/hudservice/PropertyPanel.jsm

>   appendChild(aDocument, treecols, "treecol", {
>     primary: "true",
>-    flex: 1
>+    flex: 1,
>+    hideheader: "true",
>+    ignoreincolumnpicker: "true"

I think these are redundant (hideheader because you don't specify a label, ignorecolumnpicker because the picker isn't shown to begin with), but I suppose they don't hurt to include.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 474669 [details] [diff] [review]
[checked-in] Upload 1

http://hg.mozilla.org/mozilla-central/rev/eb7dbf19dfb3