Closed Bug 590754 Opened 10 years ago Closed 10 years ago

The 'Install from file' in the add-ons manager needs to be clearer

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7

People

(Reporter: u88484, Assigned: u88484)

References

()

Details

(Whiteboard: [strings][AOMTestday][in-litmus-bug-week])

Attachments

(1 file, 2 obsolete files)

1.91 KB, patch
Unfocused
: review+
mossop
: approval2.0+
Details | Diff | Splinter Review
The 'Install from file' menu entry under the settings/options button needs to be clearer.  What exactly would the user be installing and installing it where?
In Firefox, users can install a local add-on with File/Open + navigating to an .xpi file, or by dragging an .xpi file onto a Firefox window or its application icon.  There's no need to expose the explicit option to open from a file.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
But we have, are you saying we shouldn't expose it in Firefox or that we should make it clearer everywhere?
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
(In reply to comment #2)
> But we have, are you saying we shouldn't expose it in Firefox or that we should
> make it clearer everywhere?

We definitely shouldn't expose it in Firefox.  I believe it's exposed in other products in the left column, but I'm not sure how it looks.  Kurt, would you mind attaching a screenshot of where you're seeing it on your not-Firefox?
Hrm, I just wrote an addon, and the little gear icon was the natural place for me to look for an "install from file" option. I don't understand what's wrong with keeping it there.
(In reply to comment #3)
> (In reply to comment #2)
> > But we have, are you saying we shouldn't expose it in Firefox or that we should
> > make it clearer everywhere?
> 
> Kurt, would you
> mind attaching a screenshot of where you're seeing it on your not-Firefox?

http://img812.imageshack.us/img812/6446/51311075.png
(In reply to comment #3)
> We definitely shouldn't expose it in Firefox.  I believe it's exposed in other
> products in the left column, but I'm not sure how it looks.

Wait, what? Are you forgetting bug 567127?
(In reply to comment #1)
> In Firefox, users can install a local add-on with File/Open + navigating to an
> .xpi file, or by dragging an .xpi file onto a Firefox window or its application
> icon.  There's no need to expose the explicit option to open from a file.

Neither of these methods sounds obvious to a user.
(In reply to comment #6)
> (In reply to comment #3)
> > We definitely shouldn't expose it in Firefox.  I believe it's exposed in other
> > products in the left column, but I'm not sure how it looks.
> 
> Wait, what? Are you forgetting bug 567127?

I mean we shouldn't expose this as a button or anywhere in primary UI.  In a menu, it's fine.  The gear menu's purpose is really to hold some of these advanced options, and "Install from File" would qualify.

(In reply to comment #7)
> (In reply to comment #1)
> > In Firefox, users can install a local add-on with File/Open + navigating to an
> > .xpi file, or by dragging an .xpi file onto a Firefox window or its application
> > icon.  There's no need to expose the explicit option to open from a file.
> 
> Neither of these methods sounds obvious to a user.

Nope, they aren't obvious, and that's ok.  Most users would never need to manually install an .xpi file, so the methods are both easter eggs more than exposed functionality.

(In reply to comment #0)
> The 'Install from file' menu entry under the settings/options button needs to
> be clearer.  What exactly would the user be installing and installing it where?

I've been thinking this over, Kurt, and I agree with you.  "Install from File" has a predicate and no subject.  I'm suggesting changing this string to "Install Add-on from File", similar to other menu options' verb-noun format ("Open FILE", "Close WINDOW", etc)
Whiteboard: [strings][goodfirstbug]
Assignee: nobody → supernova00
Status: REOPENED → ASSIGNED
Attached patch Patch (obsolete) — Splinter Review
Changes to 'Install Add-on from file' based on comment 8.  I'm assuming that would be a ui-review+ but requesting just in case.
Attachment #475279 - Flags: ui-review?
Attachment #475279 - Flags: review?(dao)
Attachment #475279 - Flags: ui-review? → ui-review?(jboriss)
Comment on attachment 475279 [details] [diff] [review]
Patch

You're chaning the entity name, but not the XUL file that uses it.
Attachment #475279 - Flags: review?(dao) → review-
Attached patch Patch v2 (obsolete) — Splinter Review
(In reply to comment #10)
> Comment on attachment 475279 [details] [diff] [review]
> Patch
> 
> You're chaning the entity name, but not the XUL file that uses it.

Doh!  Fixed.
Attachment #475279 - Attachment is obsolete: true
Attachment #475321 - Flags: ui-review?(jboriss)
Attachment #475321 - Flags: review?(dao)
Attachment #475279 - Flags: ui-review?(jboriss)
Comment on attachment 475321 [details] [diff] [review]
Patch v2

I should have noticed (and mentioned) this earlier, but since you're changing the entity name of installFromFile.label, you should also change the name of installFromFile.tooltip to match.

As a side-note - Dave or I are more suitable reviewers for addons manager code (you've been requesting Dao review it). And I don't think it needs ui-r - since this patch does exactly what Boriss described in comment 8 (that's been enough for us in other addons manager bugs).
Attachment #475321 - Flags: ui-review?(jboriss)
Attachment #475321 - Flags: review?(dao)
Attachment #475321 - Flags: review-
Attached patch Patch v3Splinter Review
(In reply to comment #12)
> Comment on attachment 475321 [details] [diff] [review]
> Patch v2
> 
> I should have noticed (and mentioned) this earlier, but since you're changing
> the entity name of installFromFile.label, you should also change the name of
> installFromFile.tooltip to match.
> 

I'm assuming you meant the accesskey because I couldn't find a tooltip.  I changed the 'installFromFile.accesskey' to 'installAddonFromFile.accesskey'
Attachment #475321 - Attachment is obsolete: true
Attachment #475352 - Flags: review?(bmcbride)
(In reply to comment #13)
> I'm assuming you meant the accesskey because I couldn't find a tooltip.  I
> changed the 'installFromFile.accesskey' to 'installAddonFromFile.accesskey'

Er, yea, that (sorry).
Attachment #475352 - Flags: review?(bmcbride) → review+
Flags: in-testsuite-
Flags: in-litmus-
OS: Windows 7 → All
Hardware: x86 → All
Whiteboard: [strings][goodfirstbug] → [strings]
Attachment #475352 - Flags: approval2.0? → approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/a4c37e52e753
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
Whiteboard: [strings] → [strings][AOMTestday][in-litmus-bug-week]
You need to log in before you can comment on or make changes to this bug.