590756 - The 'Update Add-ons Now' entry in the add-ons manager sounds as if updates were found and ready to be installed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[u88484]

The 'Update Add-ons Now' entry in the add-ons manager sounds as if updates were found and ready to be installed when if fact there usually isn't.  Selecting this entry starts the check for updates instead.

Comment 2

[Dave Garrett]

Please also clarify its label to say what it is in fact checking updates for. If it updates only the current pane, please say so. For example:

"Check for [extension|theme|plugin|etc.] updates"
OR
"Check for all add-on updates"

(NOT "Check for all updates" as a confused user might assume this includes application updates as well)

Comment 3

[u88484]

Alex, limi, what do you two think this entry should say?

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

I'm assuming we went with the current text because we don't just check but also apply?  I'm ok with check for updates (with the fact that they are applied automatically if any are found being left out of the string)

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #4)
> I'm assuming we went with the current text because we don't just check but also
> apply?

Yep. In most cases, there's will be no difference between checking for and installing updates. It only becomes ambiguous when any addons have been set to update manually.

Comment 6

[Dietrich Ayala (:dietrich)]

What's the conclusion here - need string changes or no? Sounds like it's not a release blocker either way...

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #6)
> What's the conclusion here

Waiting on input from Boriss.

Comment 8

[Dave Townsend [:mossop]]

Would take a patch with a ui-reviewed string (before b6) but not going to block

Comment 9

[Alex Limi (:limi) — Firefox UX Team]

Agreed with Faaborg, "Check for Updates" is good. If someone has time to write the one-line patch, please do. :)

Comment 10

[u88484]

Taking.  I'm lost on what the current string/feature freeze date is and I can't get to this until tomorrow so someone please takeover if the freeze is tomorrow before 2 PST time.

Comment 11

[u88484]

Can we reuse one of the following instead of adding yet another "Check for Updates" string to the file?:
<!ENTITY listEmpty.findUpdates.label          "Check For Updates">
or
<!ENTITY detail.checkForUpdates.label         "Check for Updates">

Comment 12

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #11)
> Can we reuse one of the following instead of adding yet another "Check for
> Updates" string to the file?:

No - its a different context, so needs to be different strings.

And string freeze is midnight Wednesday (Mountain View time/PST).

Comment 13

[u88484]

Attachment: Patch

Change 'Update Add-ons Now' to 'Check For Updates'.  I also changed the accesskey from "U" to "C" to keep the access key location in the same place in the menu entry and also because the action is to check.

Comment 14

[Dave Garrett]

Can I please get a clarification on my question in comment 2? Check for _what_ updates? All addons or just the current pane? I still don't know precisely what this function does. If it checks for all addon updates then can the new string please say so? It's ambiguous.

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

I'm assuming that it always means all types, but boriss or mossop can correct that if I'm wrong.

Comment 16

[Dave Townsend [:mossop]]

(In reply to comment #15)
> I'm assuming that it always means all types, but boriss or mossop can correct
> that if I'm wrong.

It is all types

Comment 17

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #4)
> I'm assuming we went with the current text because we don't just check but also
> apply?  I'm ok with check for updates (with the fact that they are applied
> automatically if any are found being left out of the string)

I'm fine with this.  I think it's not as descriptive as "Update Add-ons Now," since a check doesn't necessarily imply applying the updates.  It might surprise users that both a check and application has gone on.  However, for most users updating will be automatic, so I'm happy to consider applying always automatic and checking is just the manual kick.

(In reply to comment #2)
> Please also clarify its label to say what it is in fact checking updates for.
> If it updates only the current pane, please say so. For example:
> 
> "Check for [extension|theme|plugin|etc.] updates"
> OR
> "Check for all add-on updates"
> 
> (NOT "Check for all updates" as a confused user might assume this includes
> application updates as well)

Faaborg is correct in Comment 15; all add-ons are being checked with this option.  It isn't possible to check and apply in only one category.

Comment 18

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 475636 [details] [diff] [review]
Patch

Looks good to me if you change "Check For Updates" to "Check for Updates" (what we do elsewhere in our UI, and you shouldn't capitalize those words in title case).

Comment 19

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 475636 [details] [diff] [review]
Patch

Just needs the fix described in comment 18.

Comment 20

[u88484]

Attachment: Patch v2

Correctly updated the string to "Check for Updates"

Comment 21

[Dave Garrett]

(In reply to comment #17)
> Faaborg is correct in Comment 15; all add-ons are being checked with this
> option.  It isn't possible to check and apply in only one category.

I can't be the only person who has clicked this entry once per category for no reason then. Can the word "add-on" be explicitly added here for clarity then? -> "Check for Add-on Updates"

Comment 22

[u88484]

(In reply to comment #21)
> (In reply to comment #17)
> > Faaborg is correct in Comment 15; all add-ons are being checked with this
> > option.  It isn't possible to check and apply in only one category.
> 
> I can't be the only person who has clicked this entry once per category for no
> reason then. Can the word "add-on" be explicitly added here for clarity then?
> -> "Check for Add-on Updates"

You're saying that users are going to be confused that they are checking for application updates from within the add-on manager?!  That status says "Updating Addons" and then "No updates found" after clicking this entry so the user should know by the first status that it isn't checking for application updates.

Comment 23

[Robert Strong (they/them - no direct email)]

I believe he is saying that users are going to be confused that all add-ons vs. just the add-ons that are displayed are checked for updates.

Comment 24

[Dave Garrett]

Yes, thanks Robert. I'm not sure where the misunderstanding came from there. I don't want users checking for updates for the extensions pane then doing so again for themes if one check does both. The label should be precise.

The previous string had "Add-on" which I would like to keep for clarity, in fact I would prefer "Check for all Add-on Updates" if I were to get really nit-picky.

Oh, and never underestimate how confused a user can get. It is most certainly possible to find a user who would think this menu entry checks for application updates too, though I'm not too worried about that.

Comment 25

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/cc85eaa08172

Comment 26

[Aaron Train [:aaronmt]]

VERIFIED FIXED w/ Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre