Closed Bug 590794 Opened 9 years ago Closed 9 years ago
Handler" logic to Popup Notifications .jsm
Assignee: sylvain.pasche → nobody
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Assignee: nobody → sylvain.pasche
Attachment #469526 - Flags: review?(gavin.sharp)
Comment on attachment 469526 [details] [diff] [review] patch, v1 Perhaps we should just add this to options to avoid the signature change/compatibility impact...
Component: XUL Widgets → General
QA Contact: xul.widgets → general
Attachment #469526 - Flags: review?(gavin.sharp) → feedback-
Yeah, that's a good idea. I'll update the patch.
Now uses dismissalCallback property in options argument.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Any particular benefit of using .call() instead of () in this case?
That's in code I copied from Gavin's patch in attachment 448336 [details] [diff] [review]. I'm not sure about the benefit, but other places are also using call() in this file.
You need to log in before you can comment on or make changes to this bug.