Closed Bug 590794 Opened 9 years ago Closed 9 years ago

Add "dismissalHandler" logic to PopupNotifications.jsm

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7

People

(Reporter: sylvain.pasche, Assigned: sylvain.pasche)

References

Details

(Whiteboard: [doorhanger])

Attachments

(1 file, 1 obsolete file)

See bug 588266 comment 12.
Assignee: sylvain.pasche → nobody
Component: General → XUL Widgets
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Attached patch patch, v1 (obsolete) — Splinter Review
Assignee: nobody → sylvain.pasche
Attachment #469526 - Flags: review?(gavin.sharp)
Comment on attachment 469526 [details] [diff] [review]
patch, v1

Perhaps we should just add this to options to avoid the signature change/compatibility impact...
Component: XUL Widgets → General
QA Contact: xul.widgets → general
Attachment #469526 - Flags: review?(gavin.sharp) → feedback-
Yeah, that's a good idea. I'll update the patch.
Attached patch patch, v2Splinter Review
Now uses dismissalCallback property in options argument.
Attachment #469526 - Attachment is obsolete: true
Attachment #470482 - Flags: review?(gavin.sharp)
Attachment #470482 - Flags: review?(gavin.sharp)
Attachment #470482 - Flags: review+
Attachment #470482 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/c8f0c42cfa44
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Any particular benefit of using .call() instead of () in this case?
That's in code I copied from Gavin's patch in attachment 448336 [details] [diff] [review]. I'm not sure about the benefit, but other places are also using call() in this file.
Whiteboard: [doorhanger]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.