590798 - Use icon from the xpi for add-ons ready to be installed

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Sylvain Pasche]

(from bug 588266 comment 11):

We always use the InstallTrigger icon for add-ons ready to be installed. It would be nice to use the icon from the xpi if possible, but that would require extracting it somewhere since otherwise we lock the xpi on windows. And extracting it has the problem that you need to be very careful to clean it up after.

Comment 1

[Brian King [:kinger]]

What about other data that is pulled from the XPI at download -- is that just being read directly from the archive as opposed to being read from the extracted archive?

Comment 2

[Dave Townsend [:mossop]]

(In reply to comment #1)
> What about other data that is pulled from the XPI at download -- is that just
> being read directly from the archive as opposed to being read from the
> extracted archive?

At download the XPI isn't extracted at all so we pull all data directly out of it.

Comment 3

[Brian King [:kinger]]

So I am presuming jar: uris don't work on XPIs, or if they do not for images?

Seems like this issue is popping up in relation to theme previews:

https://bugzilla.mozilla.org/show_bug.cgi?id=533038#c74

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> So I am presuming jar: uris don't work on XPIs, or if they do not for images?

jar: uris work fine on XPIs and for images, but they maintain a lock on the XPI file which means that on Windows it cannot be deleted until the lock is released

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.