590805 - Sync UI: Revamp setup wizard

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Philipp von Weitershausen [:philikon]]

Revamp the setup wizard according to Faaborg's mockups.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1): Implement key generation + backup

Generate Sync Key: Implement key generation and backup (email/print/save)

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Part 2 (v1): Generate the Sync Key in the setup wizard

Generate Sync Key: Change the setup wizard to generate the Sync Key

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: Part 3 (v1): Fix up Change Passphrase dialog

Generate Sync Key: Fix up the Change/Update Passphrase dialog in the preference pane.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: Part 4 (v1): Change flow of setup wizard

Change flow of setup wizard

Comment 5

[Philipp von Weitershausen [:philikon]]

Attachment: Part 5 (v1): Restyle the setup wizard

Restyle the setup wizard

Comment 6

[Philipp von Weitershausen [:philikon]]

Attachment: Part 3 (v2): Fix up Change Passphrase dialog

Small rev on v1: Make textboxes wider to accomodate long Sync Keys.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 472537 [details] [diff] [review]
Part 1 (v1): Implement key generation + backup

>diff --git a/browser/locales/en-US/chrome/browser/syncSetup.dtd b/browser/locales/en-US/chrome/browser/syncSetup.dtd
>@@ -46,6 +46,9 @@
> <!ENTITY setup.newAccountPrefs2.title.label "Browser Sync Preferences">
> <!ENTITY syncComputerName.label       "Computer Name:">
> <!ENTITY syncComputerName.accesskey   "c">
>+
>+<!ENTITY page.syncKeyBackup.title "Your Firefox Sync Key">
>+<!ENTITY page.syncKeyBackup.descr "This secret key is used to encrypt your personal data. It is not uploaded to the server and cannot be recovered. Do not lose it or share with other people.">

style nit: line up the strings, please.

>+email.synckey.subject = Your Firefox Sync Key
>+email.synckey.body = Congratulations for signing up for Firefox Sync! Your secret Firefox Sync key is %S. Do not lose it or share with other people.
>+save.synckey.title = Save Sync Key

same here

Comment 8

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1.1): Implement key generation + backup

Addressed review comments (style nits)

Comment 9

[Philipp von Weitershausen [:philikon]]

Attachment: Part 4 (v2): Change flow of setup wizard

Small rev on v1 after bug 578671 landed in fx-sync: "Sync this computer's" --> "Sync My"

Comment 10

[Philipp von Weitershausen [:philikon]]

Attachment: Part 5 (v2): Restyle the setup wizard

Small rev on v1: Fix JAR manifest for classic Windows theme.

Comment 11

[Philipp von Weitershausen [:philikon]]

Part 1: http://hg.mozilla.org/mozilla-central/rev/e06b3042151c
Part 2: http://hg.mozilla.org/mozilla-central/rev/201cc8681096
Part 3: http://hg.mozilla.org/mozilla-central/rev/134be5ec050c
Part 4: http://hg.mozilla.org/mozilla-central/rev/9ec78f93036c
Part 5: http://hg.mozilla.org/mozilla-central/rev/728a4c3f0a53

Comment 13

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 472538 [details] [diff] [review]
Part 2 (v1): Generate the Sync Key in the setup wizard

>-          <textbox type="password" id="weavePassphrase"
>-                   onkeyup="gSyncSetup.checkFields()"
>-                   onchange="gSyncSetup.checkFields()"/>

(...)

>+      <textbox id="weavePassphrase"
>+               onkeyup="gSyncSetup.onPassphraseChange()"
>+               onchange="gSyncSetup.onPassphraseChange()"
>+               onfocus="this.select()"/>

Now it's not type="password" anymore. Was that change intentional? It looks really strange to see my key readable. :-/

Comment 14

[Philipp von Weitershausen [:philikon]]

(In reply to comment #13)
> Now it's not type="password" anymore. Was that change intentional? It looks
> really strange to see my key readable. :-/

Yes. We want users to save it by writing it down, copy'n'pasting or using one of the provided backup methods. See faaborg's mockups.

Comment 15

[Søren Munk Skrøder (extended hiatus)]

Regarding strings in syncGenericChange.properties

Is the mention of "secret phrase / passphrase"  in: 

change.synckey.error = There was an error while changing your secret phrase!
change.synckey.success = Your secret phrase was successfully changed!

intentional (as in, instead of "Sync key"), since all references to secret phrase has been changed to Sync key everywhere else by the landing yesterday ?

Comment 16

[Philipp von Weitershausen [:philikon]]

(In reply to comment #15)
> Is the mention of "secret phrase / passphrase"  in: 
> 
> change.synckey.error = There was an error while changing your secret phrase!
> change.synckey.success = Your secret phrase was successfully changed!
> 
> intentional (as in, instead of "Sync key")

I just caught this too. Not intentional, they must've slipped through the net. I already filed bug 594520.

Comment 18

[Alfred Kayser]

Images sync-usedNever.png and sync-usedBefore.png can be removed or not?

Comment 19

[Mike Connor [:mconnor]]

They can be removed, yes.  File a followup please?

Comment 20

[Philipp von Weitershausen [:philikon]]

(In reply to comment #19)
> They can be removed, yes.  File a followup please?

Filed bug 595603.

Comment 21

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #14)
> See faaborg's mockups.

Is there a link for these?

https://bugzilla.mozilla.org/attachment.cgi?id=468606

Is this it?

Comment 22

[Philipp von Weitershausen [:philikon]]

(In reply to comment #21)
> (In reply to comment #14)
> > See faaborg's mockups.
> 
> Is there a link for these?
> 
> https://bugzilla.mozilla.org/attachment.cgi?id=468606
> 
> Is this it?

Yes.

Comment 23

[Jeferson Hultmann]

Question from localizers: Should "Sync" in "Sync Key" be translated?

Comment 24

[Philipp von Weitershausen [:philikon]]

(In reply to comment #23)
> Question from localizers: Should "Sync" in "Sync Key" be translated?

That's a good question. I would say no. Sync is a brand name (see bug 596381 comment 11). That said, consistency is the most important aspect here: Firefox, Fennec and Firefox Home should all use the *same* wording in a particular language.

Comment 25

[Alex Faaborg [:faaborg] (Firefox UX)]

I assumed that both "sync" and "key" would be translated, unless Ragavan doesn't want us translating the brand name.

Comment 26

[Jack]

I know it's a bit too late to be commenting on an old bug...
I also can't find that google group thing for suggestions.

The new Sync UI looks nice, but it would look even better if it used the default set-up wizard on Aero, with it's guidelines.

The text on the current Sync UI wizard is a bit bloated, the titles are unreasonably big (especially the sync key page).

For example the initial setup page could easily be redesigned as such (quick mockup):
http://img714.imageshack.us/img714/186/aerowizard.png

Comment 27

[Philipp von Weitershausen [:philikon]]

(In reply to comment #26)
> I know it's a bit too late to be commenting on an old bug...

Indeed. Please always file a new bug or comment on ones that haven't been resolved yet. Bug 591122 seems appropriate for your suggestions.