Make it possible to disable reftests with accelerated layers enabled

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 469362 [details] [diff] [review]
add layersGPUAccelerated

This patch adds a "layersGPUAccelerated" variable to the reftests, along the lines of "d2d" and "gtk2Widget" that can be used in fails-if, etc.
Attachment #469362 - Flags: feedback?(matt.woodrow+bugzilla)
(Assignee)

Comment 1

7 years ago
Created attachment 469363 [details] [diff] [review]
add layersGPUAccelerated

now with less patch
Assignee: nobody → joe
Attachment #469362 - Attachment is obsolete: true
Attachment #469363 - Flags: feedback?(matt.woodrow+bugzilla)
Attachment #469362 - Flags: feedback?(matt.woodrow+bugzilla)
Depends on: 591150
Comment on attachment 469363 [details] [diff] [review]
add layersGPUAccelerated

Looks great! (and works great too with 591150)

It might be worthwhile to have a way to distinguish between accelerated layer manager types, OGL will almost certainly have a different set of random failures.

This should work great for the moment, about to push my patch queue to try.
Attachment #469363 - Flags: feedback?(matt.woodrow+bugzilla) → feedback+
Blocks: 591155
(Assignee)

Comment 3

7 years ago
I expect we will do platform-specific failure modes, like (layersGPUAccelerated&&linux).
(Assignee)

Comment 4

7 years ago
Created attachment 469965 [details] [diff] [review]
Just use gWindowUtils

Jeff pointed out that we already have a gWindowUtils, so let's just use that instead.
Attachment #469363 - Attachment is obsolete: true
Attachment #469965 - Flags: review?(dbaron)
Attachment #469965 - Flags: feedback?(matt.woodrow+bugzilla)
(Assignee)

Updated

7 years ago
blocking2.0: --- → beta6+
(Assignee)

Comment 5

7 years ago
Created attachment 470064 [details] [diff] [review]
update for changes in bug 590841
Attachment #469965 - Attachment is obsolete: true
Attachment #470064 - Flags: review?(dbaron)
Attachment #470064 - Flags: feedback?(matt.woodrow+bugzilla)
Attachment #469965 - Flags: review?(dbaron)
Attachment #469965 - Flags: feedback?(matt.woodrow+bugzilla)
Comment on attachment 470064 [details] [diff] [review]
update for changes in bug 590841

r=dbaron, although I wonder why we have code to deal with the possibility of not having window-utils or with it not having a compareCanvases method.  I'd rather like to see that code go away.  (And I think it has to go away for the fuzzy patch as well.)

Maybe something like "accelLayers" would be shorter than "layersGPUAccelerated", though I'm ok with it either way.
Attachment #470064 - Flags: review?(dbaron) → review+
(Assignee)

Updated

7 years ago
Attachment #470064 - Flags: feedback?(matt.woodrow+bugzilla)
http://hg.mozilla.org/mozilla-central/rev/d055207aee5e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

7 years ago
Created attachment 471963 [details] [diff] [review]
reverse condition

Frig. I accidentally reversed the condition here.
Attachment #471963 - Flags: review?(vladimir)
Attachment #471963 - Flags: review?(vladimir) → review+
http://hg.mozilla.org/mozilla-central/rev/583cc29d2a32
You need to log in before you can comment on or make changes to this bug.