Closed Bug 590939 Opened 11 years ago Closed 11 years ago

Log uploader fails on try talos runs

Categories

(Release Engineering :: General, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: catlee)

References

Details

Attachments

(1 file)

Because no 'who' property is set. e.g.

2010-08-26 08:49:04-0700 [Broker,9,10.250.50.47] Error running ['/tools/buildbot-0.8.0/bin/python', '/tools/buildbotcustom/buildbotcustom/bin/log_uploader.py', 'stage.mozilla.org', '-u', 'ffxbld', '-i', '/home/cltbld/.ssh/ffxbld_dsa', '-b', 'tryserver', '-p', 'linux', '--try', '/builds/buildbot/tests-master/tryserver_fedora_test-chrome', '26']
2010-08-26 08:49:04-0700 [Broker,9,10.250.50.47] Log output: Traceback (most recent call last):
          File "/tools/buildbotcustom/buildbotcustom/bin/log_uploader.py", line 165, in <module>
            who=build.getProperty('who'),
          File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.1-py2.6.egg/buildbot/status/builder.py", line 1149, in getProperty
            return self.properties[propname]
          File "/tools/buildbot-0.8.0/lib/python2.6/site-packages/buildbot-0.8.1-py2.6.egg/buildbot/process/properties.py", line 45, in __getitem__
            rv = self.properties[name][0]
        KeyError: 'who'
Talos jobs don't get 'who' set, so this patch makes it so the log uploader falls back to the change's author.
Attachment #469500 - Flags: review?(bhearsum)
Comment on attachment 469500 [details] [diff] [review]
Try harder to find author for try jobs

Looks good to me!
Attachment #469500 - Flags: review?(bhearsum) → review+
Comment on attachment 469500 [details] [diff] [review]
Try harder to find author for try jobs

changeset:   911:f91ce1e881ab
Attachment #469500 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.