[be] errors found by new compare-locales

RESOLVED FIXED

Status

--
critical
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Pike, Assigned: mozilla_by)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
There's a new version of compare-locales coming up, buggy still, but it already finds good stuff. Here's a preview for fx40x:

  browser/chrome/overrides/netError.dtd
          ERROR: not well-formed (invalid token) at line 136, column 61 within cspFrameAncestorBlocked.longDesc

  dom/chrome/security/caps.properties
        ERROR: Found single % at line 51, column 94 within SetPropertyDeniedOrigins

These break browser functionality.
(Assignee)

Comment 1

8 years ago
(In reply to comment #0)
> There's a new version of compare-locales coming up, buggy still, but it already
> finds good stuff. Here's a preview for fx40x:
> 
>   browser/chrome/overrides/netError.dtd
>           ERROR: not well-formed (invalid token) at line 136, column 61 within
> cspFrameAncestorBlocked.longDesc
> 

Probably, it was error of old revision. Currently it is:

<!ENTITY cspFrameAncestorBlocked.longDesc "<p>&brandShortName; прадухіліў загрузку гэтай старонкі такім спосабам, бо палітыка бяспекі змесціва старонкі не дазваляе карыстацца ім.</p>">

Before the entity missed semicolon.

> 
>   dom/chrome/security/caps.properties
>         ERROR: Found single % at line 51, column 94 within
> SetPropertyDeniedOrigins
> 

Also didn't find a problem:

SetPropertyDeniedOrigins = <%1$S> не мае дазволу прызначыць значэнне ўласцівасці %2$S.%3$S у <%4$>.


Are you going to automate filling bugs found by compare-locales?
Status: NEW → ASSIGNED
(In reply to comment #1)
> Also didn't find a problem:
> 
> SetPropertyDeniedOrigins = <%1$S> не мае дазволу прызначыць значэнне
> ўласцівасці %2$S.%3$S у <%4$>.
It should be <%4$S> (note missing S after $)
(Reporter)

Comment 3

8 years ago
FWIW, I compared to the signed-off version at the time of filing the bug, and not necessarily head of default. Rerun with the current sign-off, and the %4$S one is the one left.
(Assignee)

Comment 4

8 years ago
(In reply to comment #2)
> (In reply to comment #1)
> > Also didn't find a problem:
> > 
> > SetPropertyDeniedOrigins = <%1$S> не мае дазволу прызначыць значэнне
> > ўласцівасці %2$S.%3$S у <%4$>.
> It should be <%4$S> (note missing S after $)

Thanks.

Fixed by c9437cc37a57 rev.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.