Closed Bug 590970 Opened 12 years ago Closed 12 years ago

nsnull == PL_strcasecmp is wrong

Categories

(Core :: Plug-ins, defect)

x86
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

(Whiteboard: [build_warning][nsnull])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
PL_strcasecmp doesn't return a pointer, so shouldn't be compared to nsnull.
Flags: in-testsuite-
Attachment #469520 - Flags: review?
Attachment #469520 - Flags: review? → review?(joshmoz)
Attachment #469520 - Flags: review?(joshmoz) → review+
Attachment #469520 - Flags: approval2.0?
Attachment #469520 - Flags: approval2.0? → approval2.0+
Attachment #469520 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/2a26b596a01d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
You need to log in before you can comment on or make changes to this bug.