Implement and use TypedMultipleChoiceField

VERIFIED FIXED in 2.4.1

Status

support.mozilla.org
Code Quality
P4
normal
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: paulc, Assigned: paulc)

Tracking

unspecified
2.4.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

(Assignee)

Description

7 years ago
Django ticket 12398 [1] adds a TypedMultipleChoiceField.

However, since that's been waiting along for a while, and we're using this in more than one place already, let's just implement a version of it that works for our needs, and use it. This should clean up some code.

We may be able to just copy this entirely:
http://code.djangoproject.com/attachment/ticket/12398/12398-TypedMultipleChoiceField-r11901.diff


[1] http://code.djangoproject.com/ticket/12398
(Assignee)

Comment 1

7 years ago
Not crucial to 2.3.
Target Milestone: 2.3 → 2.4
Target Milestone: 2.4 → Future
(Assignee)

Comment 2

7 years ago
Already did this as part of bug 611071, though it's a separate commit so I could update the comment to reflect it.
Target Milestone: Future → 2.4.1
(Assignee)

Comment 3

7 years ago
This was actually the most work out of these 3 bugs :)
(bug 611071 and bug 621790)

But the search form's clean method is much, uh, cleaner now.
https://github.com/jsocol/kitsune/commit/a568cd975a9aab666f932174a2e438e8fb4b0c8a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Whiteboard: [qa-]
Closed as [qa-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.