Closed
Bug 590977
Opened 15 years ago
Closed 15 years ago
buildbot ssh-shell.sh slave script adds test arguments to filelist even if the file has already been added
Categories
(Tamarin Graveyard :: Tools, defect)
Tamarin Graveyard
Tools
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cpeyer, Assigned: cpeyer)
Details
Attachments
(1 file)
|
3.11 KB,
patch
|
brbaker
:
review+
|
Details | Diff | Splinter Review |
When test arguments are passed to the ssh-shell script, all filenames are parsed out for copying to the device. There is a small bug where if the same file is passed more than once (see regress/security/bug555059a.abc_.avm_args) then the script will add it twice to the filelist. When cleaning up, the script will attempt to delete the same file twice and fail on the second try, causing the test to fail.
|
Assignee | |
Comment 1•15 years ago
|
||
Also added some comments.
|
|
||
Updated•15 years ago
|
Attachment #469527 -
Flags: review?(brbaker) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed to redux:
http://hg.mozilla.org/tamarin-redux/rev/4b0b47f7ff15
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•