5910 - prefs file should be named "prefs.js" not "prefs50.js"

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P2)

Description

[mcmullen]

Needs to be fixed before we ship.

Comment 1

[leger]

Is this mac only?

Comment 2

[mcmullen]

No. All platforms. I'll change that, thanks.

Comment 3

[mcmullen]

Accepting bug

Comment 4

[don]

Move this to M8 (or maybe later ...)

Comment 5

[Chris McAfee]

M9, giving to don for re-assigning.

Comment 6

[don]

dp, can your team handle this bug?

Comment 7

[neeti]

The prefs file  is being renamed to prefs50.js in nsPrefMigration.cpp.
Reassigning bug to racham.

Comment 8

[Cathleen]

Don (dbragg), does your migration tool create pref50.js?
Looks like people wants to rename it back to pref.js instead.

Comment 9

[racham]

Also FileSpec needs to change the name from prefs50.js to prefs.js.
I will fix it. Follwoing is the lxr serach for the users of prefs50.js.
Adding the sspitzer and chuang to the cc list.

/xpfe/appshell/src/nsFileLocations.cpp, line 336 -- *this += "prefs50.js";
/mailnews/base/src/nsMsgAccountManager.cpp, line 1082 -- message += ". Keep in
mind, it will be stored in the clear in your
prefs50.js file";
/mailnews/mime/src/mimemoz2.h, line 51 -- #define MIME_PREFS_FILE "prefs50.js"

In /mailnews/base/src/nsMsgAccountManager.cpp the usage is inside a comment and
MIME_PREFS_FILE in /mailnews/mime/src/mimemoz2.h file does not seem to be
getting used in any where else.

Seth and Candice, please let me know if you are using/planning on using the name
of the prefs file in the near future. I will change the name to prefs.js (from
prefs50.js) on all platforms once I hear from you.

Comment 10

[chuang]

I don't use any pref file name in address book.

Comment 11

[(not reading, please use [e-mail] instead)]

I've fixed the one in nsMsgAccountManager.cpp, thanks for the heads up.

removing chuang from the cc list, and adding rhp, since he owns mime.

Comment 12

[rhp (gone)]

thanks...that actually helped me cleanup since libmime wasn't really using that
define.

- rhp

Comment 13

[racham]

I checked in a fix for this. It's prefs.js now on all platforms. No one should
be hardcoding name "prefs.js". One should always use FileLocations service
(nsFileLocator) to get the name of the preferences file
(nsSpecialFileSpec::App_PreferencesFile50). Marking fixed.

Comment 14

[(not reading, please use [e-mail] instead)]

so how are you going to tell everyone about this change?

QA especially needs to know about this, if they are going to be affected.

Comment 15

[lchiang]

I'll send email out to allclientqa on this.  We should post this on the external
newsgroups if haven't done so already so external folks will get a heads-up.
I'll notify the marketing folks I know who are using 5.0 about this.

Comment 16

[racham]

I have posted the news to netscape.public.mozilla.prefs, builds, seamonkey and
general newsgroups.

Thanks Lisa, for taking care of internal customers.

Comment 17

[racham]

However, there is a side effect to this change.
Users who have been using apprunner (earlier builds) prior to this checkin (Aug
9th 1999, 2:06pm), will have prefs50.js in their profile directories. With this
change, the apprunner (created out of builds from now on) is going to look for
prefs.js instead of prefs50.js. So, all those prefs (in prefs50.js) will get
ignored.

If you are using profiles created prior to this check in,
you will have to change the name of the prefs file from prefs50.js to prefs.js.

If you have no previous profiles, you will not see this problem.

Sorry for the inconvenience.

Bhuvan

Comment 18

[lchiang]

Yes, this is exactly what I conveyed to allclientqa and to the marketing folks.

Comment 19

[Paul MacQuiddy]

verified