591071 - Reloading about:addons with the "Recent Updates" pane open doesn't show the pane button at the left side

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100826 Minefield/4.0b5pre

When you upgrade an add-on and restart Firefox with the "Recent Updates" pane open, the category button at the left side is not shown. The pane will be selected after a restart. See the screenshot.

Steps:
1. Install an outdated version of an extension, i.e. Dom Inspector 2.0.6
2. Update the extension
3. Open the "Recent Updates" pane
4. Restart Firefox via the restart now link

After the restart you will see the "Recent Updates" pane open but no category button for it.

Comment 1

[Martijn Wargers (dead)]

Also happens by just closing the about:addons tab, then reopening it.

Comment 2

[Dave Garrett]

Or just hitting refresh.

Rather than showing the category button, if the recent updates pane is to be hidden in the update button, then it should probably just forget about its selection instead. If about:addons is opened with it previously showing the recent updates pane, it should instead show extensions or get addons.

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple fix, before bailing out early if the category is already selected make sure it is visible and enabled.

Comment 4

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/d73fe0475b74

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101111 Firefox/4.0b8pre