591086 - Crash in search form processing

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Jeff Balogh (:jbalogh)]

File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/search/views.py", line 274, in search
   return _personas(request)

 File "/data/amo_python/www/preview/zamboni/apps/search/views.py", line 163, in _personas
   query = form.cleaned_data.get('q', '')

AttributeError: 'SecondarySearchForm' object has no attribute 'cleaned_data'


<WSGIRequest
GET:<QueryDict: {u'q': [u''], u'pp': [u'http://www.google.com/'], u'advanced': [u'/'], u'cat': [u'personas']}>,
POST:<QueryDict: {}>,

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/f42518f

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; if you try to search again from the 404 page you get when loading that URL, you get a domain-less URL:

https://en-us/firefox/search/?q=term&cat=personas&lver=any&pid=1&sort=&pp=20&lup=&advanced=%2F

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Dave: Jeff tells me this is a completely separate bug, so feel free to close if it's not caused by that patch, and I'll just file a spinoff bug.

BTW, the minimal testcase is searching from: https://preview.addons.mozilla.org/en-US/firefox/search//f

Comment 4

[Jeff Balogh (:jbalogh)]

(In reply to comment #3)
> BTW, the minimal testcase is searching from:
> https://preview.addons.mozilla.org/en-US/firefox/search//f

The problem comes from the double slash in the url.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; now returns a 404, and I filed bug 591820 about comment 2 comment 4.

Comment 6

[Jeff Balogh (:jbalogh)]

Traceback (most recent call last):

 File "/data/amo_python/www/next/zamboni/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/next/zamboni/apps/search/views.py", line 257, in search
   return _collections(request)

 File "/data/amo_python/www/next/zamboni/apps/search/views.py", line 191, in _collections
   query = form.cleaned_data.get('q', '')

AttributeError: 'SecondarySearchForm' object has no attribute 'cleaned_data'

/en-US/mobile/search/?q=k%27s+recommendation&cat=collections&pp=20&sortby=new'

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/d3ec23a

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; manually tested this, as well as re-ran my fuzzing tool.