Closed
Bug 591104
Opened 14 years ago
Closed 13 years ago
Mirrored images in about:robots are useless
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: mak, Assigned: mak)
Details
(Keywords: rtl)
Attachments
(1 file, 1 obsolete file)
2.95 KB,
patch
|
mstange
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
we can mirror a single image using css, rtl images are taking space without a reason, we can save 13KB. Unfortunatly I discovered -moz-element crashes on about: pages, but there is a bug for that!
Comment 1•14 years ago
|
||
Instead of using a CSS background, couldn't you use the image as a :before content? Like this: #errorPageContainer::before { content: url('chrome://browser/content/aboutRobots-icon.png'); position: absolute; } body[dir=rtl] #errorPageContainer::before { -moz-transform: scaleX(-1); } Then you wouldn't need JavaScript.
Assignee | ||
Comment 2•14 years ago
|
||
it's possible, will check that, thanks.
Assignee | ||
Comment 3•14 years ago
|
||
Works flawlessy, even better since I can avoid the crash, and looks like you just offered to review this change :D
Attachment #469684 -
Attachment is obsolete: true
Attachment #470448 -
Flags: review?(mstange)
Assignee | ||
Comment 4•14 years ago
|
||
fixed dependency since does not depend anymore from moz-element
Updated•14 years ago
|
Attachment #470448 -
Flags: review?(mstange) → review+
Comment 5•14 years ago
|
||
Dolske, is my review sufficient here or do you want to review it, too?
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 470448 [details] [diff] [review] patch v1.1 asking approval in the meanwhile, imo markus review is more than enough here, also considering the code I'm touching.
Assignee | ||
Updated•14 years ago
|
Attachment #470448 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #470448 -
Flags: approval2.0? → approval2.0+
Comment 7•13 years ago
|
||
(In reply to comment #5) > Dolske, is my review sufficient here or do you want to review it, too? I suppose it's technically insufficient, so rs=me to make it good for sure. :) I assume this was checked with Ehsan's "Force RTL Direction" extension to make sure it all looks the same as before?
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to comment #7) > I assume this was checked with Ehsan's "Force RTL Direction" extension to make > sure it all looks the same as before? I did not have the extension off-hand when I checked, but I had tested manually inverting the body direction.
Assignee | ||
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ac7ef72afa34
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
You need to log in
before you can comment on or make changes to this bug.
Description
•