591104 - Mirrored images in about:robots are useless

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak]]

Attachment: patch v1.0

we can mirror a single image using css, rtl images are taking space without a reason, we can save 13KB.

Unfortunatly I discovered -moz-element crashes on about: pages, but there is a bug for that!

Comment 1

[Markus Stange [:mstange]]

Instead of using a CSS background, couldn't you use the image as a :before content? Like this:

#errorPageContainer::before {
  content: url('chrome://browser/content/aboutRobots-icon.png');
  position: absolute;
}

body[dir=rtl] #errorPageContainer::before {
  -moz-transform: scaleX(-1);
}

Then you wouldn't need JavaScript.

Comment 2

[Marco Bonardo [:mak]]

it's possible, will check that, thanks.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Works flawlessy, even better since I can avoid the crash, and looks like you just offered to review this change :D

Comment 4

[Marco Bonardo [:mak]]

fixed dependency since does not depend anymore from moz-element

Comment 5

[Markus Stange [:mstange]]

Dolske, is my review sufficient here or do you want to review it, too?

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 470448 [details] [diff] [review]
patch v1.1

asking approval in the meanwhile, imo markus review is more than enough here, also considering the code I'm touching.

Comment 7

[Justin Dolske [:Dolske]]

(In reply to comment #5)
> Dolske, is my review sufficient here or do you want to review it, too?

I suppose it's technically insufficient, so rs=me to make it good for sure. :)

I assume this was checked with Ehsan's "Force RTL Direction" extension to make sure it all looks the same as before?

Comment 8

[Marco Bonardo [:mak]]

(In reply to comment #7)
> I assume this was checked with Ehsan's "Force RTL Direction" extension to make
> sure it all looks the same as before?

I did not have the extension off-hand when I checked, but I had tested manually inverting the body direction.

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/ac7ef72afa34