Mirrored images in about:robots are useless

RESOLVED FIXED in Firefox 4.0b7

Status

()

Firefox
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({rtl})

Trunk
Firefox 4.0b7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 469684 [details] [diff] [review]
patch v1.0

we can mirror a single image using css, rtl images are taking space without a reason, we can save 13KB.

Unfortunatly I discovered -moz-element crashes on about: pages, but there is a bug for that!
Instead of using a CSS background, couldn't you use the image as a :before content? Like this:

#errorPageContainer::before {
  content: url('chrome://browser/content/aboutRobots-icon.png');
  position: absolute;
}

body[dir=rtl] #errorPageContainer::before {
  -moz-transform: scaleX(-1);
}

Then you wouldn't need JavaScript.
(Assignee)

Comment 2

7 years ago
it's possible, will check that, thanks.
(Assignee)

Comment 3

7 years ago
Created attachment 470448 [details] [diff] [review]
patch v1.1

Works flawlessy, even better since I can avoid the crash, and looks like you just offered to review this change :D
Attachment #469684 - Attachment is obsolete: true
Attachment #470448 - Flags: review?(mstange)
(Assignee)

Updated

7 years ago
No longer depends on: 590404
(Assignee)

Comment 4

7 years ago
fixed dependency since does not depend anymore from moz-element
Attachment #470448 - Flags: review?(mstange) → review+
Dolske, is my review sufficient here or do you want to review it, too?
(Assignee)

Comment 6

7 years ago
Comment on attachment 470448 [details] [diff] [review]
patch v1.1

asking approval in the meanwhile, imo markus review is more than enough here, also considering the code I'm touching.
(Assignee)

Updated

7 years ago
Attachment #470448 - Flags: approval2.0?
Attachment #470448 - Flags: approval2.0? → approval2.0+
(In reply to comment #5)
> Dolske, is my review sufficient here or do you want to review it, too?

I suppose it's technically insufficient, so rs=me to make it good for sure. :)

I assume this was checked with Ehsan's "Force RTL Direction" extension to make sure it all looks the same as before?
(Assignee)

Comment 8

7 years ago
(In reply to comment #7)
> I assume this was checked with Ehsan's "Force RTL Direction" extension to make
> sure it all looks the same as before?

I did not have the extension off-hand when I checked, but I had tested manually inverting the body direction.

Updated

7 years ago
Keywords: rtl
(Assignee)

Comment 9

7 years ago
http://hg.mozilla.org/mozilla-central/rev/ac7ef72afa34
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
You need to log in before you can comment on or make changes to this bug.