Closed Bug 591104 Opened 10 years ago Closed 10 years ago
Mirrored images in about:robots are useless
we can mirror a single image using css, rtl images are taking space without a reason, we can save 13KB. Unfortunatly I discovered -moz-element crashes on about: pages, but there is a bug for that!
it's possible, will check that, thanks.
Works flawlessy, even better since I can avoid the crash, and looks like you just offered to review this change :D
fixed dependency since does not depend anymore from moz-element
Attachment #470448 - Flags: review?(mstange) → review+
Dolske, is my review sufficient here or do you want to review it, too?
Comment on attachment 470448 [details] [diff] [review] patch v1.1 asking approval in the meanwhile, imo markus review is more than enough here, also considering the code I'm touching.
Attachment #470448 - Flags: approval2.0? → approval2.0+
(In reply to comment #5) > Dolske, is my review sufficient here or do you want to review it, too? I suppose it's technically insufficient, so rs=me to make it good for sure. :) I assume this was checked with Ehsan's "Force RTL Direction" extension to make sure it all looks the same as before?
(In reply to comment #7) > I assume this was checked with Ehsan's "Force RTL Direction" extension to make > sure it all looks the same as before? I did not have the extension off-hand when I checked, but I had tested manually inverting the body direction.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
You need to log in before you can comment on or make changes to this bug.