Use MOZ_ACCELERATED in GetLayerManager

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: Joe Drew (not getting mail))

Tracking

unspecified
x86
Windows 7
Points:
---

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 469751 [details] [diff] [review]
move MOZ_ACCELERATED usage

We should use the environment variable MOZ_ACCELERATED, in addition to the prefs, in GetLayerManager, because we don't always have an nsXULWindow to read MOZ_ACCELERATED for us. We don't need to read it in nsXULWindow at all if we do it here.
Attachment #469751 - Flags: review?(roc)
Attachment #469751 - Flags: review?(bas.schouten)
Drive by review comment, we need to check *acceleratedEnv != '0' so people can pref it off without having to remove the env var entirely.
Blocks: 590844
Comment on attachment 469751 [details] [diff] [review]
move MOZ_ACCELERATED usage

Looks good, we should be clear we're changing the semantics so that MOZ_ACCELERATED=0 also enables it by default.
Attachment #469751 - Flags: review?(bas.schouten) → review+
(Assignee)

Updated

8 years ago
blocking2.0: --- → beta6+
(Assignee)

Comment 3

8 years ago
Created attachment 470065 [details] [diff] [review]
make MOZ_ACCELERATED=0 work

Bas and Matt pointed out that MOZ_ACCELERATED=0 would result in us enabling hardware accelerated layers. That's wrong, and this patch fixes us.
Assignee: nobody → joe
Attachment #469751 - Attachment is obsolete: true
Attachment #470065 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/5dbf817b799d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.