591151 - Allow auto edit-mode on key press when awesomescreen is open, but readonly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We recently landed a patch in bug 590779 to not put the URL textbox into edit-mode when initially tapped. On devices with hard keyboard, we should try to go into edit-mode when a key is pressed, instead of requiring a second tap.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I don't think this messes up any logic in BrowserUI._editURI, but I haven't tested many situations.

The basic tests I did seem to work well.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Works on N900 hard keyboard as well as desktop

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 469758 [details] [diff] [review]
patch

I will replace 
+          const nsIDOMKeyEvent = Components.interfaces.nsIDOMKeyEvent;
+          if (event.keyCode == nsIDOMKeyEvent.DOM_VK_RETURN)

by

+          if (event.keyCode == aEvent.DOM_VK_RETURN)

while checkin

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/dfdfc11d89b6

Yeah!

Comment 5

[Aakash Desai [:aakashd]]

So, I'm a bit confused. Is the intended behavior to not allow users to type in the url bar until they tap on it again in the awesomebar?

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

Comment 8

[Aakash Desai [:aakashd]]

litmus testcases updated to regression test this bug:
https://litmus.mozilla.org/show_test.cgi?id=12323
https://litmus.mozilla.org/show_test.cgi?id=12317
https://litmus.mozilla.org/show_test.cgi?id=12330
https://litmus.mozilla.org/show_test.cgi?id=12313
https://litmus.mozilla.org/show_test.cgi?id=12335