591182 - Recent Updates pane needs a max number of visible updates (remove older ones)

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b5pre) Gecko/20100826 Minefield/4.0b5pre

At the moment the Recent Updates pane doesn't remove older updates which means that you end-up with a huge list of entries over time. We should think about how long updates should be visible in this pane. I don't think we should do it by time but having a maximum number of entries we want to show in this pane. The question is how many it should be? 10? 15? 20?

Comment 1

[Dave Townsend [:mossop]]

I think we said it was going to be time based didn't we?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> I think we said it was going to be time based didn't we?

Sounds like I missed that information then. Lets get feedback from Boriss.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

It should be doing this already, based on time (2 days). See:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#1758

Its working correctly for me.

I think having it based on time makes the most sense - if you're looking for something that updated recently, you don't want to see something from last year, just because you've had few updates. Similarly, if you updated a huge number of addons in the past couple of days, you want to see all of those updates - not just 10 of them.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, what's the easiest way to update the updateDate? Are those seconds? Even when I modify that value it still shows August 30th for me in the Add-ons Manager.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #4)
> Hm, what's the easiest way to update the updateDate? Are those seconds? Even
> when I modify that value it still shows August 30th for me in the Add-ons
> Manager.

Hm, you can't alter the property on the Addon object.... and it will refresh from there every time you switch to that pane. So I think you'll have to alter the data in extensions.sqlite. Off the top of my head, I *think* that stores it in milliseconds (Dave can confirm).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #5)
> from there every time you switch to that pane. So I think you'll have to alter
> the data in extensions.sqlite. Off the top of my head, I *think* that stores it
> in milliseconds (Dave can confirm).

That's what I did but the UI always shows the current date and doesn't remove the entry from the recent updates pane when it's too far in the past.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, the more simpler solution is to modify the current date and time. I have checked it with two days in the future and it works fine. Means we are doing the right thing here already. Lets close it as WFM then.